test: unset NODE_OPTIONS for cctest#31594
Closed
addaleax wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
The test may fail otherwise because of behaviour changes caused by setting the environment variable. Fixes: nodejs#31585
richardlau
approved these changes
Jan 31, 2020
awibox
approved these changes
Jan 31, 2020
lpinca
approved these changes
Jan 31, 2020
devsnek
approved these changes
Jan 31, 2020
cjihrig
approved these changes
Feb 1, 2020
jasnell
approved these changes
Feb 1, 2020
Trott
approved these changes
Feb 2, 2020
Collaborator
Collaborator
Collaborator
Collaborator
jasnell
pushed a commit
that referenced
this pull request
Feb 3, 2020
The test may fail otherwise because of behaviour changes caused by setting the environment variable. Fixes: #31585 PR-URL: #31594 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Member
|
Landed in d435dc4 |
codebytere
pushed a commit
that referenced
this pull request
Feb 17, 2020
The test may fail otherwise because of behaviour changes caused by setting the environment variable. Fixes: #31585 PR-URL: #31594 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 15, 2020
The test may fail otherwise because of behaviour changes caused by setting the environment variable. Fixes: #31585 PR-URL: #31594 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Mar 17, 2020
The test may fail otherwise because of behaviour changes caused by setting the environment variable. Fixes: #31585 PR-URL: #31594 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 30, 2020
The test may fail otherwise because of behaviour changes caused by setting the environment variable. Fixes: #31585 PR-URL: #31594 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test may fail otherwise because of behaviour changes caused
by setting the environment variable.
Fixes: #31585
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes