src: use hex not decimal in IsArrayIndex#31758
Closed
codebytere wants to merge 1 commit intonodejs:masterfrom
Closed
src: use hex not decimal in IsArrayIndex#31758codebytere wants to merge 1 commit intonodejs:masterfrom
codebytere wants to merge 1 commit intonodejs:masterfrom
Conversation
jasnell
approved these changes
Feb 12, 2020
Contributor
|
@codebytere thanks for the PR, and apologies for the compiler issue! This is actually a completely daft bug, which I included a fix for, rolled into the PR at https://github.com/nodejs/node/pull/31625/files#diff-4a5950be44f56dfca2e7fa3c4e1fc0e4R966, although that PR with the current approval will take another 5 days to land unless we get another approval there. If that is the case, and you need this sooner, it may well be better to just port that fix here. |
Member
|
Yeah, I think the compiler is correct to warn here, and we should use its suggestion rather than just make the warning go away :) |
cjihrig
approved these changes
Feb 13, 2020
devnexen
approved these changes
Feb 13, 2020
lundibundi
approved these changes
Feb 13, 2020
Collaborator
addaleax
requested changes
Feb 13, 2020
Member
addaleax
left a comment
There was a problem hiding this comment.
Since this would be ready to land now, I’ll make it explicit that the previous code was buggy and we should not remove the warning about the bug (and rather fix it)
ed59501 to
6cb838e
Compare
Collaborator
codebytere
added a commit
that referenced
this pull request
Feb 14, 2020
PR-URL: #31758 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Member
Author
|
Landed in 3a22549 |
codebytere
added a commit
that referenced
this pull request
Feb 17, 2020
PR-URL: #31758 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
codebytere
added a commit
that referenced
this pull request
Mar 15, 2020
PR-URL: #31758 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
codebytere
added a commit
that referenced
this pull request
Mar 17, 2020
PR-URL: #31758 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
codebytere
added a commit
that referenced
this pull request
Mar 30, 2020
PR-URL: #31758 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
codebytere
added a commit
to electron/electron
that referenced
this pull request
Apr 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Electron, clang enforces
-Wxor-used-as-pow, so the previous line would cause the following error:The simplest solution i see is to just use hex to clarify intent for the compiler, and so this PR does so.
cc @guybedford
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes