src: allow unique_ptrs with custom deleter in memory tracker#31870
Closed
jasnell wants to merge 1 commit intonodejs:masterfrom
Closed
src: allow unique_ptrs with custom deleter in memory tracker#31870jasnell wants to merge 1 commit intonodejs:masterfrom
jasnell wants to merge 1 commit intonodejs:masterfrom
Conversation
Originally landed in the QUIC repo Original review metadata: ``` PR-URL: nodejs/quic#145 Reviewed-By: James M Snell <jasnell@gmail.com> ```
addaleax
approved these changes
Feb 19, 2020
devnexen
approved these changes
Feb 19, 2020
joyeecheung
approved these changes
Feb 19, 2020
lundibundi
approved these changes
Feb 19, 2020
Collaborator
cjihrig
approved these changes
Feb 20, 2020
jasnell
pushed a commit
that referenced
this pull request
Feb 24, 2020
Originally landed in the QUIC repo Original review metadata: ``` PR-URL: nodejs/quic#145 Reviewed-By: James M Snell <jasnell@gmail.com> ``` PR-URL: #31870 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Member
Author
|
Landed in e68d4c6 |
codebytere
pushed a commit
that referenced
this pull request
Feb 27, 2020
Originally landed in the QUIC repo Original review metadata: ``` PR-URL: nodejs/quic#145 Reviewed-By: James M Snell <jasnell@gmail.com> ``` PR-URL: #31870 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 15, 2020
Originally landed in the QUIC repo Original review metadata: ``` PR-URL: nodejs/quic#145 Reviewed-By: James M Snell <jasnell@gmail.com> ``` PR-URL: #31870 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Mar 17, 2020
Originally landed in the QUIC repo Original review metadata: ``` PR-URL: nodejs/quic#145 Reviewed-By: James M Snell <jasnell@gmail.com> ``` PR-URL: #31870 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 30, 2020
Originally landed in the QUIC repo Original review metadata: ``` PR-URL: nodejs/quic#145 Reviewed-By: James M Snell <jasnell@gmail.com> ``` PR-URL: #31870 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Authored by @addaleax and originally landed in the QUIC repo. Separating it out from the QUIC PR. This does not have any QUIC specific bits...
Original review metadata:
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes