test: remove common.port from test-tls-securepair-client#32024
Merged
Trott merged 0 commit intonodejs:masterfrom Mar 2, 2020
Merged
test: remove common.port from test-tls-securepair-client#32024Trott merged 0 commit intonodejs:masterfrom
Trott merged 0 commit intonodejs:masterfrom
Conversation
Collaborator
Member
Author
|
This could use some reviews. @nodejs/testing |
bcoe
approved these changes
Mar 2, 2020
Contributor
bcoe
left a comment
There was a problem hiding this comment.
👍 I like this cleanup a lot.
sam-github
approved these changes
Mar 2, 2020
Contributor
sam-github
left a comment
There was a problem hiding this comment.
Seems obviously better, if CI likes it I do, too.
Member
Author
|
Landed in 9ac42f1 |
MylesBorins
pushed a commit
that referenced
this pull request
Mar 4, 2020
OpenSSL s_server accepts port 0 as an indicator to use an open port provided by the operating system. Use that instead of common.PORT in the test. Remove 500ms delay added in 8e46167. Hopefully the race condition in OpenSSL s_server has been fixed and/or the change to port 0 means that the server is listening by the time the ACCEPT text is printed and the setTimeout() is no longer necessary. PR-URL: #32024 Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 16, 2020
OpenSSL s_server accepts port 0 as an indicator to use an open port provided by the operating system. Use that instead of common.PORT in the test. Remove 500ms delay added in 8e46167. Hopefully the race condition in OpenSSL s_server has been fixed and/or the change to port 0 means that the server is listening by the time the ACCEPT text is printed and the setTimeout() is no longer necessary. PR-URL: #32024 Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Mar 17, 2020
OpenSSL s_server accepts port 0 as an indicator to use an open port provided by the operating system. Use that instead of common.PORT in the test. Remove 500ms delay added in 8e46167. Hopefully the race condition in OpenSSL s_server has been fixed and/or the change to port 0 means that the server is listening by the time the ACCEPT text is printed and the setTimeout() is no longer necessary. PR-URL: #32024 Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 30, 2020
OpenSSL s_server accepts port 0 as an indicator to use an open port provided by the operating system. Use that instead of common.PORT in the test. Remove 500ms delay added in 8e46167. Hopefully the race condition in OpenSSL s_server has been fixed and/or the change to port 0 means that the server is listening by the time the ACCEPT text is printed and the setTimeout() is no longer necessary. PR-URL: #32024 Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenSSL s_server accepts port 0 as an indicator to use an open port
provided by the operating system. Use that instead of common.PORT in the
test.
Remove 500ms delay added in 8e46167.
Hopefully the race condition in OpenSSL s_server has been fixed and/or
the change to port 0 means that the server is listening by the time
the ACCEPT text is printed and the setTimeout() is no longer necessary.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes