Conversation
common added at 6d7f862e4a encoding updated to 39b27a7875 resources updated to 5d33b4da92 using: `git node wpt ...`
2 tasks
Member
Member
What does this mean? There are test failures added in this update (but I don't see them in the CI?) or there are new test testing failures? |
Member
Author
|
@joyeecheung running output |
Member
|
@bmeck You can edit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds several failures mostly due to how things are stringified. Unclear what direction is normally taken as updating the platform test values seems a bit much. Was intending just to update
encoding, but due to harness changescommonandresourcesalso needed updates.Using
git node wpt ...Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes