module: fix initial ModuleWrap with non-string source#33443
Closed
himself65 wants to merge 1 commit intonodejs:masterfrom
Closed
module: fix initial ModuleWrap with non-string source#33443himself65 wants to merge 1 commit intonodejs:masterfrom
himself65 wants to merge 1 commit intonodejs:masterfrom
Conversation
acbe4ff to
793b36f
Compare
addaleax
approved these changes
May 17, 2020
Contributor
Member
Author
|
note that expected behavior should throw a JS error |
Collaborator
cjihrig
approved these changes
May 17, 2020
Member
|
I'll fix my PR today
…On Sun, May 17, 2020, 7:58 AM Colin Ihrig ***@***.***> wrote:
***@***.**** approved this pull request.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#33443 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABZJI5QJVWPOLRWXBS7X5TRR7NN7ANCNFSM4NDG4E2A>
.
|
Collaborator
Member
|
I've rebased my PR, @himself65 would it be ok to merge my PR, it has slightly different semantics since it won't stringify every kind of object that makes it to ModuleWrap. That behavior is slightly different from this PR and I'm curious if you had a use case for values that are not Buffers or TypedArrays being passed as source text before I move forward with my PR. |
Collaborator
Contributor
|
I would prefer if we can land @bmeck's PR as well since it reserves API space while handling and documenting edge cases. |
Member
Author
|
#32202 fixed this, closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #33441
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes