doc: eliminate dead space in API section's sidebar#33469
Closed
Alhadis wants to merge 1 commit intonodejs:masterfrom
Cutlery-Drawer:nav-ux-polish
Closed
doc: eliminate dead space in API section's sidebar#33469Alhadis wants to merge 1 commit intonodejs:masterfrom Cutlery-Drawer:nav-ux-polish
Alhadis wants to merge 1 commit intonodejs:masterfrom
Cutlery-Drawer:nav-ux-polish
Conversation
This commit improves overall usability on desktop by removing the "dead" (non-interactive) regions between links in the API section's navigation. No visible changes have been made; this enhancement is purely tactile in nature.
jasnell
approved these changes
May 19, 2020
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
May 23, 2020
This commit improves overall usability on desktop by removing the "dead" (non-interactive) regions between links in the API section's navigation. No visible changes have been made; this enhancement is purely tactile in nature. PR-URL: nodejs#33469 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Member
|
Landed in f14229e 🎉 |
Contributor
Author
codebytere
pushed a commit
that referenced
this pull request
Jun 18, 2020
This commit improves overall usability on desktop by removing the "dead" (non-interactive) regions between links in the API section's navigation. No visible changes have been made; this enhancement is purely tactile in nature. PR-URL: #33469 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
codebytere
pushed a commit
that referenced
this pull request
Jun 18, 2020
This commit improves overall usability on desktop by removing the "dead" (non-interactive) regions between links in the API section's navigation. No visible changes have been made; this enhancement is purely tactile in nature. PR-URL: #33469 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
This commit improves overall usability on desktop by removing the "dead" (non-interactive) regions between links in the API section's navigation. No visible changes have been made; this enhancement is purely tactile in nature. PR-URL: #33469 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
codebytere
pushed a commit
that referenced
this pull request
Jul 8, 2020
This commit improves overall usability on desktop by removing the "dead" (non-interactive) regions between links in the API section's navigation. No visible changes have been made; this enhancement is purely tactile in nature. PR-URL: #33469 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds some UX garnish to the API section's nav-menu by removing the non-clickable regions between each link.
Checklist
make -j4 test(Unix), orvcbuild test(Windows) passesDescription
Here's a before-and-after of the change — the interactive regions of each link are highlighted in red:
NB: The easiest way to preview these changes is to open an API page, pop the DevTools open, and run this snippet in the console:
Click to show
Implementation details
This was a Q&D addition to my user stylesheet to address a pet UX peeve of mine (nav-menus that don't make ergonomic use of useful, perfectly-clickable empty space). Having said that, I'm in the dark as to what other pages on
nodejs.orgwould be affected by these changes, so I exercised caution at the expense of weird-looking CSS like this:I can simplify this mess once I know which selectors and measurements I can mess with. Feedback welcome.