doc: avoid using deprecated connection property#35439
Merged
lpinca merged 1 commit intonodejs:masterfrom Oct 4, 2020
Merged
Conversation
Collaborator
|
Review requested:
|
addaleax
approved these changes
Oct 1, 2020
rexagod
approved these changes
Oct 1, 2020
HarshithaKP
approved these changes
Oct 1, 2020
Trott
approved these changes
Oct 1, 2020
cjihrig
approved these changes
Oct 1, 2020
jasnell
approved these changes
Oct 1, 2020
Member
jasnell
left a comment
There was a problem hiding this comment.
This shouldn't need to wait to land. fast-track?
Collaborator
Collaborator
gireeshpunathil
approved these changes
Oct 3, 2020
trivikr
approved these changes
Oct 4, 2020
`request.connection` and `response.connection` are deprecated. Use `request.socket` and `response.socket` instead. PR-URL: nodejs#35439 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Pranshu Srivastava <rexagod@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
34329c5 to
2979721
Compare
Member
Author
|
Landed in 2979721. |
danielleadams
pushed a commit
that referenced
this pull request
Oct 6, 2020
`request.connection` and `response.connection` are deprecated. Use `request.socket` and `response.socket` instead. PR-URL: #35439 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Pranshu Srivastava <rexagod@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
`request.connection` and `response.connection` are deprecated. Use `request.socket` and `response.socket` instead. PR-URL: nodejs#35439 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Pranshu Srivastava <rexagod@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
request.connectionandresponse.connectionare deprecated. Userequest.socketandresponse.socketinstead.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes