Don't 'exit' a script meant to be "source"d#35520
Closed
fdgonthier wants to merge 1 commit intonodejs:masterfrom
Closed
Don't 'exit' a script meant to be "source"d#35520fdgonthier wants to merge 1 commit intonodejs:masterfrom
fdgonthier wants to merge 1 commit intonodejs:masterfrom
Conversation
Contributor
|
@fdgonthier can you please rebase against master? |
Running exit in a script meant to be sourced means the user shell will exit, which prevents seeing the error message, and is generally very annoying.
a54a2ee to
fb7894a
Compare
Contributor
|
I've gone ahead and rebased against master, can anyone confirm this change works? Seems useful for building for android |
Member
|
Since #35519 is the issue this fixes, I think it would make sense to mention this at the end of the commit message: |
Collaborator
Contributor
Commit Queue failed- Loading data for nodejs/node/pull/35520 ✔ Done loading data for nodejs/node/pull/35520 ----------------------------------- PR info ------------------------------------ Title Don't 'exit' a script meant to be "source"d (#35520) Author François-Denis Gonthier (@fdgonthier, first-time contributor) Branch fdgonthier:issue-35519 -> nodejs:master Labels android, build Commits 1 - Don't 'exit' a script meant to be "source"d Committers 1 - Myles Borins PR-URL: https://github.com/nodejs/node/pull/35520 Fixes: https://github.com/nodejs/node/issues/35519 Reviewed-By: Michaël Zasso ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/35520 Fixes: https://github.com/nodejs/node/issues/35519 Reviewed-By: Michaël Zasso -------------------------------------------------------------------------------- ✔ Last GitHub Actions successful ℹ Last Full PR CI on 2020-12-27T13:43:24Z: https://ci.nodejs.org/job/node-test-pull-request/35092/ - Querying data for job/node-test-pull-request/35092/ ✔ Build data downloaded ✔ Last Jenkins CI successful ℹ This PR was created on Tue, 06 Oct 2020 15:32:18 GMT ✔ Approvals: 1 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/35520#pullrequestreview-558928296 -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/master up to date... From https://github.com/nodejs/node * branch master -> FETCH_HEAD ✔ origin/master is now up-to-date - Downloading patch for 35520 From https://github.com/nodejs/node * branch refs/pull/35520/merge -> FETCH_HEAD ✔ Fetched commits as acaa58e60260..fb7894a45d1f -------------------------------------------------------------------------------- Auto-merging android-configure warning: inexact rename detection was skipped due to too many files. warning: you may want to set your merge.renamelimit variable to at least 1469 and retry the command. [master 137faf9812] Don't 'exit' a script meant to be "source"d Author: François-Denis Gonthier Date: Tue Oct 6 11:29:25 2020 -0400 1 file changed, 3 insertions(+), 3 deletions(-) ✔ Patches applied -------------------------------------------------------------------------------- --------------------------------- New Message ---------------------------------- Don't 'exit' a script meant to be "source"dhttps://github.com/nodejs/node/actions/runs/447274178 |
Member
|
Landed in 6c50d74 |
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running exit in a script meant to be sourced means the user shell will
exit, which prevents seeing the error message, and is generally very
annoying.
Fixes: #35519
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes