child_process: refactor to use more primordials#36269
Closed
Lxxyx wants to merge 1 commit intonodejs:masterfrom
Closed
child_process: refactor to use more primordials#36269Lxxyx wants to merge 1 commit intonodejs:masterfrom
Lxxyx wants to merge 1 commit intonodejs:masterfrom
Conversation
085d730 to
d1e3196
Compare
aduh95
reviewed
Nov 27, 2020
Contributor
aduh95
left a comment
There was a problem hiding this comment.
Thanks for your PR. Please remove the unrelated changes, and I've also let a comment on an optimisation we can make.
d1e3196 to
95ece51
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
|
The benchmark suite is crashing before completion, I've opened #36295 to fix that. |
Contributor
Contributor
|
Benchmark results: Details |
aduh95
approved these changes
Dec 2, 2020
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Collaborator
Contributor
|
Landed in a897a25...f7dd330 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Dec 3, 2020
PR-URL: #36269 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Dec 7, 2020
PR-URL: #36269 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Merged
cjihrig
pushed a commit
to cjihrig/node
that referenced
this pull request
Dec 8, 2020
PR-URL: nodejs#36269 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes