test: update to improve terminology#37011
Conversation
|
The change in |
|
@joyeecheung can you confirm that in terms of excluding tests that fail there is no better way to handle excluding the tests than what I've done? |
|
@mhdawson You can use "skip" instead of "fail" if you don't need the test expectation to be changed once the failure is fixed. But using "fail" is OK as well, and it prompts people to update the expectation. |
|
@joyeecheung thanks |
|
Issue already open for test which failed in CI #36867 |
|
Resume build to try to get to green: https://ci.nodejs.org/job/node-test-pull-request/35737/ |
|
One more attempt: https://ci.nodejs.org/job/node-test-pull-request/35760/ as there was another unrelated failure (build time out) |
Update common section in wpt to incorporate improved terminology fixed upstream in web-platform-tests/wpt#27152 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: nodejs#37011 Reviewed-By: Milad Fa <mfarazma@redhat.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
Landed in 9603e4a |
Update common section in wpt to incorporate improved terminology fixed upstream in web-platform-tests/wpt#27152 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #37011 Reviewed-By: Milad Fa <mfarazma@redhat.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Update common section in wpt to incorporate
improved terminology fixed upstream in
web-platform-tests/wpt#27152
Signed-off-by: Michael Dawson mdawson@devrus.com