process: use frozen array for process.allowedNodeEnvironmentFlags#37171
Closed
aduh95 wants to merge 4 commits intonodejs:masterfrom
Closed
process: use frozen array for process.allowedNodeEnvironmentFlags#37171aduh95 wants to merge 4 commits intonodejs:masterfrom
aduh95 wants to merge 4 commits intonodejs:masterfrom
Conversation
Maintain no-op calls of `Set` prototype methods to `process.allowedNodeEnvironmentFlags` for backward compatibility.
Member
|
I don't like having a weird set-like-array-object around - wouldn't it be simpler to subclass SafeSet in a way that noops on mutations? |
Member
|
Oh, I see that's what the current code does, then the issue is getting external set prototype calls on the set mutating it? |
Contributor
Author
|
Yes, I did a proposal in #36660 to circumvent the direct |
benjamingr
reviewed
Feb 1, 2021
mscdex
reviewed
Feb 1, 2021
Contributor
|
This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maintain no-op calls of
Setprototype methods toprocess.allowedNodeEnvironmentFlagsfor backward compatibility.Labeled as
semver-majoras it makes following code throw:Originally suggested by @Trott in #36660 (review).