Skip to content

deps: upgrade npm to 7.5.2#37191

Closed
ruyadorno wants to merge 1 commit intonodejs:masterfrom
npm:npm-7.5.2
Closed

deps: upgrade npm to 7.5.2#37191
ruyadorno wants to merge 1 commit intonodejs:masterfrom
npm:npm-7.5.2

Conversation

@ruyadorno
Copy link
Member

@ruyadorno ruyadorno commented Feb 2, 2021

v7.5.2 (2021-02-02)

BUG FIXES

DEPENDENCIES

@nodejs-github-bot nodejs-github-bot added the npm Issues and PRs related to the npm client dependency or the npm registry. label Feb 2, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 2, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/35896/

@bricss bricss mentioned this pull request Feb 2, 2021
Merged
@targos
Copy link
Member

targos commented Feb 2, 2021

@ruyadorno should I postpone #37183 to tomorrow to include this?

@ruyadorno
Copy link
Member Author

ruyadorno commented Feb 2, 2021

it would be nice to have, since there are some important npx and npm init related bug fixes - that said I don't want to give you extra work @targos and I also think it's ok to wait to land these in the next release cycle 😅

@ruyadorno
Copy link
Member Author

ruyadorno commented Feb 2, 2021

also, just synced with the rest of the team and the consensus is that there's no need to postpone!

MylesBorins
MylesBorins approved these changes Feb 2, 2021
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

Trott
Trott approved these changes Feb 2, 2021
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp LGTM

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 2, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/35904/

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 2, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 2, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/35907/

@MylesBorins
Copy link
Contributor

MylesBorins commented Feb 3, 2021

fast track?

@MylesBorins MylesBorins added the fast-track PRs that do not need to wait for 72 hours to land. label Feb 3, 2021
@Trott
Copy link
Member

Trott commented Feb 3, 2021

Landed in 861a396

@Trott Trott closed this Feb 3, 2021
Trott pushed a commit that referenced this pull request Feb 3, 2021
@ruyadorno @Trott
deps: upgrade npm to 7.5.2
861a396 
PR-URL: #37191
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
danielleadams pushed a commit that referenced this pull request Feb 16, 2021
@ruyadorno @danielleadams
deps: upgrade npm to 7.5.2
e63b380 
PR-URL: #37191
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
This was referenced Feb 16, 2021
Closed
Merged
@wraithgar wraithgar deleted the npm-7.5.2 branch June 26, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

+1 more reviewer

@MylesBorins MylesBorins MylesBorins approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 72 hours to land. npm Issues and PRs related to the npm client dependency or the npm registry.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ruyadorno @nodejs-github-bot @targos @MylesBorins @Trott @gireeshpunathil @aduh95