http: server check Host header in request, to meet RFC 7230 5.4 requirement#39322
Closed
wwwzbwcom wants to merge 5 commits intonodejs:mainfrom
Closed
http: server check Host header in request, to meet RFC 7230 5.4 requirement#39322wwwzbwcom wants to merge 5 commits intonodejs:mainfrom
wwwzbwcom wants to merge 5 commits intonodejs:mainfrom
Conversation
Member
|
could you please add some test cases? Under |
Contributor
Author
Working on it. Also, I wonder how to increamental build under windows, every time I run test or build with |
mscdex
reviewed
Jul 9, 2021
jasnell
approved these changes
Jul 9, 2021
Contributor
Author
|
Is there any additional work needed for this PR? |
Member
|
@wwwzbwcom I'm sorry for this PR got staled.. It seems that it is conflict with current |
Contributor
|
Hey, this would need a rebase to solve the git conflicts. |
Member
|
Superseded by #45597 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relate issues: #3094 #39033
According to RFC 2730 5.4 https://datatracker.ietf.org/doc/html/rfc7230#section-5.4:
A server MUST respond with a 400 (Bad Request) status code to any HTTP/1.1 request message that lacks a Host header field and to any request message that contains more than one Host header field or a Host header field with an invalid field-value.