Fix minor spelling errors in URL documents#39666
Closed
howiezhao wants to merge 1 commit intonodejs:masterfrom
howiezhao:patch-1
Closed
Fix minor spelling errors in URL documents#39666howiezhao wants to merge 1 commit intonodejs:masterfrom howiezhao:patch-1
howiezhao wants to merge 1 commit intonodejs:masterfrom
howiezhao:patch-1
Conversation
jasnell
approved these changes
Aug 5, 2021
aduh95
approved these changes
Aug 5, 2021
Contributor
|
Fast-track has been requested by @aduh95. Please 👍 to approve. |
lpinca
approved these changes
Aug 5, 2021
tniessen
approved these changes
Aug 5, 2021
Member
tniessen
left a comment
There was a problem hiding this comment.
LGTM. Thank you for your contribution, @howiezhao. It would be great if you could change the commit message according to our guidelines by force-pushing the commit with the correct commit message. However, we can also fix this while merging your commit.
PR-URL: #39666 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Contributor
|
Landed in 8bfb4b9, thanks for the contribution 🎉 |
danielleadams
pushed a commit
that referenced
this pull request
Aug 16, 2021
PR-URL: #39666 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The example code uses the
myURLvariable on the previous line, and the same variable should be used on the next line