tools: update remark-preset-lint-node to 3.1.0#40166
Closed
Trott wants to merge 1 commit intonodejs:masterfrom
Closed
tools: update remark-preset-lint-node to 3.1.0#40166Trott wants to merge 1 commit intonodejs:masterfrom
Trott wants to merge 1 commit intonodejs:masterfrom
Conversation
Update remark-preset-lint-node from 3.0.1 to 3.1.0. This is a necessary step before we can use the lint preset to format markdown files.
Contributor
Commit Queue failed- Loading data for nodejs/node/pull/40166 ✔ Done loading data for nodejs/node/pull/40166 ----------------------------------- PR info ------------------------------------ Title tools: update remark-preset-lint-node to 3.1.0 (#40166) Author Rich Trott (@Trott) Branch Trott:format-pre -> nodejs:master Labels tools, author ready Commits 1 - tools: update remark-preset-lint-node to 3.1.0 Committers 1 - Rich Trott PR-URL: https://github.com/nodejs/node/pull/40166 Reviewed-By: Tobias Nießen ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/40166 Reviewed-By: Tobias Nießen -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 20 Sep 2021 18:56:22 GMT ✔ Approvals: 1 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/40166#pullrequestreview-759197535 ✖ This PR needs to wait 117 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub Actions successful ℹ Green GitHub Actions CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1263549090 |
Member
Author
|
@nodejs/linting This could use a second review/approval. |
aduh95
approved these changes
Sep 22, 2021
Contributor
|
Landed in c89d519...51d2623 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Sep 22, 2021
Update remark-preset-lint-node from 3.0.1 to 3.1.0. This is a necessary step before we can use the lint preset to format markdown files. PR-URL: #40166 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 4, 2021
Update remark-preset-lint-node from 3.0.1 to 3.1.0. This is a necessary step before we can use the lint preset to format markdown files. PR-URL: #40166 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update remark-preset-lint-node from 3.0.1 to 3.1.0. This is a necessary
step before we can use the lint preset to format markdown files.