Skip to content

doc: add missing word in readable.read() text#41524

Merged
nodejs-github-bot merged 1 commit intonodejs:masterfrom
Trott:stream-typo
Jan 14, 2022
Merged

doc: add missing word in readable.read() text#41524
nodejs-github-bot merged 1 commit intonodejs:masterfrom
Trott:stream-typo

Conversation

@Trott
Copy link
Member

@Trott Trott commented Jan 14, 2022

This adds a missing is in the readable.read() text and makes
small style adjustments.

@Trott
doc: add missing word in readable.read() text
278b9ce 
This adds a missing _is_ in the readable.read() text and makes
small style adjustments.
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels Jan 14, 2022
@Trott
Copy link
Member Author

Trott commented Jan 14, 2022 •
edited
Loading

To avoid any data is/data are bikeshedding:

From the Microsoft Writing Style Guide:

Always use data with a singular verb, even if you're talking about more than one data set. Don't use the data are.

And from doc/README.md:

For topics not covered here, refer to the Microsoft Writing Style Guide.

@Trott Trott added the fast-track PRs that do not need to wait for 72 hours to land. label Jan 14, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jan 14, 2022

Fast-track has been requested by @Trott. Please 👍 to approve.

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 14, 2022
@benjamingr
Copy link
Member

benjamingr commented Jan 14, 2022

Change LGTM.

Note - in the future since terminology consistency is important and it's unfortunately pretty nuanced at times, please ping @nodejs/streams when making changes w.r.t the docs about how streams work :)

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 14, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 14, 2022
@nodejs-github-bot nodejs-github-bot merged commit 08fc4b5 into nodejs:master Jan 14, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 14, 2022

Landed in 08fc4b5

@nodejs-github-bot nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Jan 14, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 14, 2022

Commit Queue failed
- Loading data for nodejs/node/pull/41524
✔  Done loading data for nodejs/node/pull/41524
----------------------------------- PR info ------------------------------------
Title      doc: add missing word in readable.read() text (#41524)
Author     Rich Trott  (@Trott)
Branch     Trott:stream-typo -> nodejs:master
Labels     doc, stream, fast-track, author ready
Commits    1
 - doc: add missing word in readable.read() text
Committers 1
 - Rich Trott 
PR-URL: https://github.com/nodejs/node/pull/41524
Reviewed-By: Richard Lau 
Reviewed-By: Tobias Nießen 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Darshan Sen 
Reviewed-By: Benjamin Gruenbaum 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/41524
Reviewed-By: Richard Lau 
Reviewed-By: Tobias Nießen 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Darshan Sen 
Reviewed-By: Benjamin Gruenbaum 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 14 Jan 2022 14:43:56 GMT
   ✔  Approvals: 5
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/41524#pullrequestreview-852999920
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/41524#pullrequestreview-853005515
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/41524#pullrequestreview-853008485
   ✔  - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/41524#pullrequestreview-853059323
   ✔  - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/41524#pullrequestreview-853119680
   ℹ  This PR is being fast-tracked
   ⚠  This PR was merged on Fri, 14 Jan 2022 17:42:38 GMT
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/1698846568

@Trott Trott deleted the stream-typo branch January 14, 2022 18:31
targos pushed a commit that referenced this pull request Jan 16, 2022
@Trott @targos
doc: add missing word in readable.read() text
abbfed8 
This adds a missing _is_ in the readable.read() text and makes
small style adjustments.

PR-URL: #41524
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@targos targos mentioned this pull request Jan 16, 2022
Merged
mawaregetsuka pushed a commit to mawaregetsuka/node that referenced this pull request Jan 17, 2022
@Trott @mawaregetsuka
doc: add missing word in readable.read() text
b007532 
This adds a missing _is_ in the readable.read() text and makes
small style adjustments.

PR-URL: nodejs#41524
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
thedull pushed a commit to thedull/node that referenced this pull request Jan 18, 2022
@Trott @thedull
doc: add missing word in readable.read() text
683bc61 
This adds a missing _is_ in the readable.read() text and makes
small style adjustments.

PR-URL: nodejs#41524
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
@Trott @Linkgoron
doc: add missing word in readable.read() text
3e68c17 
This adds a missing _is_ in the readable.read() text and makes
small style adjustments.

PR-URL: nodejs#41524
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@Trott @danielleadams
doc: add missing word in readable.read() text
2bea4bd 
This adds a missing _is_ in the readable.read() text and makes
small style adjustments.

PR-URL: #41524
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingr benjamingr benjamingr approved these changes

@tniessen tniessen tniessen approved these changes

@richardlau richardlau richardlau approved these changes

@aduh95 aduh95 aduh95 approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 72 hours to land. stream Issues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Trott @benjamingr @nodejs-github-bot @tniessen @richardlau @aduh95 @RaisinTen