test: improve readline/emitKeypressEvents.js coverage#42908
Merged
nodejs-github-bot merged 2 commits intonodejs:masterfrom May 22, 2022
Merged
test: improve readline/emitKeypressEvents.js coverage#42908nodejs-github-bot merged 2 commits intonodejs:masterfrom
nodejs-github-bot merged 2 commits intonodejs:masterfrom
Conversation
Member
|
@nodejs/testing @nodejs/readline This pull request needs some reviews. |
Contributor
Author
|
@RaisinTen Can help review this pr? thanks~ |
This comment was marked as outdated.
This comment was marked as outdated.
27 tasks
Contributor
Author
|
need to run CI again? |
This comment was marked as outdated.
This comment was marked as outdated.
28 tasks
This comment was marked as outdated.
This comment was marked as outdated.
juanarbol
approved these changes
May 20, 2022
Contributor
Author
|
CI seems to have failed several times, do I need to change anything? |
Member
|
Nope, no additional change required. Will rerun the build! |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This was referenced May 21, 2022
Collaborator
Collaborator
|
Landed in ddd2a18 |
This was referenced May 23, 2022
19 tasks
bengl
pushed a commit
that referenced
this pull request
May 30, 2022
PR-URL: #42908 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Merged
juanarbol
pushed a commit
that referenced
this pull request
May 31, 2022
PR-URL: #42908 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jun 27, 2022
PR-URL: #42908 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
PR-URL: #42908 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
PR-URL: #42908 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
PR-URL: nodejs/node#42908 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous test case did not cover the case where the stream add
keypresslistener beforeemitKeypressEventsand listens first and then removes thekeypresslistener.Refer: https://coverage.nodejs.org/coverage-68fb0bf553e2af3e/lib/internal/readline/emitKeypressEvents.js.html