Conversation
Collaborator
|
Review requested:
|
aduh95
reviewed
Jul 6, 2022
| * `hostname` {string} Host name to resolve. | ||
| * `options` {Object} | ||
| * `ttl` {boolean} Retrieve the Time-To-Live value (TTL) of each record. | ||
| * `ttl` {boolean} Retrieves the Time-To-Live value (TTL) of each record. |
Contributor
There was a problem hiding this comment.
Not sure this is correct, the option doesn't retrieve anything, however setting it to true instruct the API to retrieve the value.
Contributor
Author
There was a problem hiding this comment.
yes, I understand, but it does retrieve the time to live value when ttl option is used, in this case the ttl is 60, so by writing retrieves, it is stating that if we use hostname with option ttl, we are presented with an array which has ttl value and the api works in the background
Contributor
Author
|
This PR is a reattempt of PR #43694 |
Contributor
Oh nice, let's reopen that other PR and land it then, it would be much simpler! Thanks, closing this one now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed some grammar in dns doc