test: mark sequential/test-gc-http-client-onerror as flaky#43957
Closed
mcollina wants to merge 1 commit intonodejs:mainfrom
Closed
test: mark sequential/test-gc-http-client-onerror as flaky#43957mcollina wants to merge 1 commit intonodejs:mainfrom
mcollina wants to merge 1 commit intonodejs:mainfrom
Conversation
Signed-off-by: Matteo Collina <hello@matteocollina.com>
tniessen
approved these changes
Jul 23, 2022
Member
tniessen
left a comment
There was a problem hiding this comment.
I think sequential/test-gc-http-client is also flaky (just like sequential/test-gc-http-client-timeout).
Member
Author
|
Definitely. I opened a PR at a time as it seems how it was done other times, but I'm also ok in massively adding all of them in one. |
Collaborator
Member
|
It looks like the issue will be fixed by #43949. |
17 tasks
Contributor
|
FYI, #43949 has merged to main branch and fixed |
This was referenced Jul 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Matteo Collina hello@matteocollina.com
Ref: nodejs/reliability#329