tools: update lint-md-dependencies to @rollup/plugin-commonjs@23.0.2 @rollup/plugin-node-resolve@15.0.1 rollup@3.2.3#45237
Merged
nodejs-github-bot merged 1 commit intomainfrom Oct 31, 2022
Conversation
aduh95
approved these changes
Oct 30, 2022
Contributor
|
Fast-track has been requested by @aduh95. Please 👍 to approve. |
VoltrexKeyva
approved these changes
Oct 30, 2022
MoLow
approved these changes
Oct 30, 2022
Member
MoLow
left a comment
There was a problem hiding this comment.
not sure what needs to be done in cases like this where the commit message is too long
Member
I usually check out the branch, edit the commit message, and force-push it back to the feature branch. I'll do that now. |
Update @rollup/plugin-commonjs@23.0.2, @rollup/plugin-node-resolve@15.0.1, and rollup@3.2.3.
d5e5fa3 to
72e4905
Compare
Trott
approved these changes
Oct 30, 2022
Collaborator
Author
MoLow
approved these changes
Oct 30, 2022
Contributor
Another solution would be to leave it as is and to land it manually, editing the commit message at that time. It's the same result, the only difference being that you save one CI cycle. Speaking of CI, I don't think we need to have a passing Jenkins CI for that kind of change (it's only changing the name of a class), all the CI failures look unrelated anyway. |
Member
I guess I'm still scarred from that one time that a change in lint-md caused CI failures in...like...was it build-without-intl or something? I forget. Some non-default CI build that we test. |
Collaborator
Author
19 tasks
RaisinTen
approved these changes
Oct 31, 2022
Collaborator
Author
Collaborator
Author
|
Landed in 548f505 |
17 tasks
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 1, 2022
Update @rollup/plugin-commonjs@23.0.2, @rollup/plugin-node-resolve@15.0.1, and rollup@3.2.3. PR-URL: #45237 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Merged
15 tasks
lucshi
pushed a commit
to lucshi/node
that referenced
this pull request
Nov 9, 2022
Update @rollup/plugin-commonjs@23.0.2, @rollup/plugin-node-resolve@15.0.1, and rollup@3.2.3. PR-URL: nodejs#45237 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 10, 2022
Update @rollup/plugin-commonjs@23.0.2, @rollup/plugin-node-resolve@15.0.1, and rollup@3.2.3. PR-URL: #45237 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
Update @rollup/plugin-commonjs@23.0.2, @rollup/plugin-node-resolve@15.0.1, and rollup@3.2.3. PR-URL: #45237 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
Update @rollup/plugin-commonjs@23.0.2, @rollup/plugin-node-resolve@15.0.1, and rollup@3.2.3. PR-URL: #45237 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 3, 2023
Update @rollup/plugin-commonjs@23.0.2, @rollup/plugin-node-resolve@15.0.1, and rollup@3.2.3. PR-URL: #45237 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated update of lint-md-dependencies to @rollup/plugin-commonjs@23.0.2 @rollup/plugin-node-resolve@15.0.1 rollup@3.2.3.