Skip to content

deps: update simdutf to 3.1.0#46257

Closed
nodejs-github-bot wants to merge 2 commits intomainfrom
actions/tools-update-simdutf
Closed

deps: update simdutf to 3.1.0#46257
nodejs-github-bot wants to merge 2 commits intomainfrom
actions/tools-update-simdutf

Conversation

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot commented Jan 18, 2023 •
edited by anonrig
Loading

Removes the need for #46256
Fixes #46235

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Jan 18, 2023
@anonrig anonrig self-assigned this Jan 18, 2023
@anonrig anonrig requested a review from addaleax January 18, 2023 21:00
@anonrig anonrig force-pushed the actions/tools-update-simdutf branch from c8f5ff7 to c85f1df Compare January 18, 2023 21:03
@anonrig anonrig added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label Jan 18, 2023
@addaleax addaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 18, 2023
@addaleax addaleax mentioned this pull request Jan 18, 2023
Closed
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 18, 2023
@nodejs-github-bot
Copy link
Collaborator Author

nodejs-github-bot commented Jan 18, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/49060/

@anonrig anonrig added the fast-track PRs that do not need to wait for 72 hours to land. label Jan 18, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 18, 2023

Fast-track has been requested by @anonrig. Please 👍 to approve.

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 18, 2023
Trott
Trott approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM.

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 18, 2023
@nodejs-github-bot
Copy link
Collaborator Author

nodejs-github-bot commented Jan 18, 2023

Landed in d896f5b...95c064d

nodejs-github-bot added a commit that referenced this pull request Jan 18, 2023
@nodejs-github-bot
deps: update simdutf to 3.1.0
7b2f1a1 
PR-URL: #46257
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Jan 18, 2023
@anonrig @nodejs-github-bot
src: fix endianness of simdutf
95c064d 
PR-URL: #46257
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@addaleax addaleax deleted the actions/tools-update-simdutf branch January 19, 2023 12:45
RafaelGSS pushed a commit that referenced this pull request Jan 20, 2023
@nodejs-github-bot @RafaelGSS
deps: update simdutf to 3.1.0
26cde8e 
PR-URL: #46257
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Jan 20, 2023
@anonrig @RafaelGSS
src: fix endianness of simdutf
e482d5e 
PR-URL: #46257
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jan 20, 2023
Merged
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
@nodejs-github-bot @juanarbol
deps: update simdutf to 3.1.0
594d638 
PR-URL: #46257
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
@anonrig @juanarbol
src: fix endianness of simdutf
3536efe 
PR-URL: #46257
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@juanarbol juanarbol mentioned this pull request Jan 28, 2023
Merged
juanarbol pushed a commit that referenced this pull request Jan 31, 2023
@nodejs-github-bot @juanarbol
deps: update simdutf to 3.1.0
b7fe8c7 
PR-URL: #46257
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
juanarbol pushed a commit that referenced this pull request Jan 31, 2023
@anonrig @juanarbol
src: fix endianness of simdutf
646cadc 
PR-URL: #46257
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Qard Qard Qard approved these changes

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@anonrig anonrig anonrig approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

Assignees

@anonrig anonrig

Labels

commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. dependencies Pull requests that update a dependency file. fast-track PRs that do not need to wait for 72 hours to land. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

segfault with shared builtin

6 participants

@nodejs-github-bot @Qard @Trott @addaleax @anonrig @joyeecheung