Conversation
This updates all sources in deps/openssl/openssl by:
$ git clone git@github.com:quictls/openssl.git
$ cd openssl
$ git checkout openssl-3.0.8+quic
$ cd ../node/deps/openssl
$ rm -rf openssl
$ cp -R ../../../openssl openssl
$ rm -rf openssl/.git* openssl/.travis*
$ git add --all openssl
$ git commit openssl
This comment was marked as outdated.
This comment was marked as outdated.
|
The Windows on ARM64 failure is an upstream OpenSSL bug on all the new OpenSSL releases. The 32-bit Windows x86 failure is something we hit before -- I think we were floating a patch for it on top of OpenSSL? |
There's a note about 32-bit Windows in https://github.com/nodejs/node/blob/main/doc/contributing/maintaining-openssl.md#2-execute-make-in-depsopensslconfig-directory |
c05532a to
aeeafb7
Compare
|
@RafaelGSS Looks like something has gone awry with the config generation for this PR. "/Users/runner/work/node/node/deps/openssl/openssl/include/openssl/opensslconf.h:14:11: fatal error: 'openssl/configuration.h' file not found\n" +
'# include <openssl/configuration.h>\n' +
' ^~~~~~~~~~~~~~~~~~~~~~~~~\n' +
'1 error generated.\n' + |
After an OpenSSL source update, all the config files need to be
regenerated and committed by:
$ make -C deps/openssl/config
$ git add deps/openssl/config/archs
$ git add deps/openssl/openssl
$ git commit
Original commit message:
rsa: add msvc intrinsic for non x64 platforms
_umul128() is x86_64 (x64) only, while __umulh() works everywhere, but
doesn't generate optimal code on x64
Refs: openssl/openssl#20244
aeeafb7 to
8dc2d94
Compare
|
Landed in f369c0a...9f468cc |
|
This doesn't land cleanly on v19.x, If this is supposed to land can someone please backport |
|
This landed in v19.x via #46573 as part of the recent security releases. |
Updated openssl dep to openssl-3.0.8 using the maintenance guide.
Refs: https://mta.openssl.org/pipermail/openssl-announce/2023-February/000251.html