Conversation
d31feb8 to
1f683af
Compare
|
Does the second commit also need to update deprecations.md to change the deprecation from documentation-only to runtime? (And if so, does that make this semver major?) Other than sorting that out, this looks good to me. Thanks for the follow-through on this. |
It is already deprecated. I just cherry picked and added the |
Oh, right, pending deprecation, and we're just refloating the change after updating the library. Yeah, that's fine. Thanks. Sorry for my misunderstanding! |
|
Note that this should probably not be landed using the CQ, otherwise the commit message for 1f683af would have two PR-URL metadata which could break our automations. How do you usually do when we float patch, e.g. on top of V8? |
Should I remove the PR-URL from the description of the commit? |
9e9129e to
82b66f6
Compare
|
If you look at how it's done in #46445, all the metadata is stripped from the commit-message. I suggest doing that here as well. Regarding 9e9129e, we wouldn't want to land this as a separate commit: node/doc/contributing/pull-requests.md Lines 540 to 541 in 5af2021 Instead, you can use git commit --fixup 097a2806023b5a8498f792eff97e35c04588e04b to add follow up fixup! commit(s) that the CQ can understand and squash into the correct commit without you needing to rebase.
|
tniessen
left a comment
There was a problem hiding this comment.
I don't have the necessary context here, but for what it's worth, if the third commit is necessary due to the first commit, then the first commit is not self-contained and the third commit should likely be squashed into the first instead.
82b66f6 to
2a97606
Compare
Not really. deps: silence irrelevant V8 warning is the only commit cherry-picked from |
|
Landed in d1b29b4...629a8fa |
PR-URL: #46719 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>
PR-URL: #46719 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>
PR-URL: #46719 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>
PR-URL: #46719 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>
PR-URL: #46719 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>
PR-URL: #46719 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Resolving 3rd item on fixing jsdoc references in punycode.
Referencing: #45524 (comment)
cc @Trott