src: fix useless call in permission.cc#46833
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Feb 27, 2023
Merged
Conversation
Trott
approved these changes
Feb 25, 2023
This comment was marked as outdated.
This comment was marked as outdated.
apapirovski
approved these changes
Feb 25, 2023
anonrig
approved these changes
Feb 25, 2023
addaleax
reviewed
Feb 25, 2023
Member
addaleax
left a comment
There was a problem hiding this comment.
I agree that the current state here isn't ideal, but I'd rather fix it by doing proper error handling (i.e. return; on empty Maybe) than using .Check() and adding potential crashes here
Member
Author
|
@addaleax I went with |
Member
|
@tniessen I think in ideal world we'd also handle errors from the string creation functions, but since they can only fail (afaik) if the strings exceed the maximum length of strings allowed by V8, and they (currently) only accept input that is already defined at compile time, so I don't have strong feelings about those (The extra |
Member
Author
|
@addaleax Thank you, that makes sense. I'll update it soon. |
FromMaybe() has no side effects and the return value is ignored. Instead, if Set() fails, then another exception is pending, so return early.
5989869 to
0e95c5a
Compare
Collaborator
addaleax
approved these changes
Feb 25, 2023
RaisinTen
approved these changes
Feb 26, 2023
Collaborator
cjihrig
approved these changes
Feb 26, 2023
13 tasks
Collaborator
|
Landed in 3abbc38 |
16 tasks
targos
pushed a commit
that referenced
this pull request
Mar 13, 2023
FromMaybe() has no side effects and the return value is ignored. Instead, if Set() fails, then another exception is pending, so return early. PR-URL: #46833 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FromMaybe()has no side effects and the return value is ignored. UseCheck()instead to ensure that the operation succeeded.