test: increase timeout of wait for socket to be closed#47316
Closed
ywave620 wants to merge 2 commits intonodejs:mainfrom
Closed
test: increase timeout of wait for socket to be closed#47316ywave620 wants to merge 2 commits intonodejs:mainfrom
ywave620 wants to merge 2 commits intonodejs:mainfrom
Conversation
For a passive closing socket, wait 100 ms for it to be closed.
Contributor
Author
|
100ms is enough for the stress test to paas in my mac. roger@MacBook-Pro node-contribute % python3 tools/test.py parallel/test-http-remove-connection-header-persists-connection -j10 --repeat 1000
[00:47|% 100|+ 1000|- 0]: Done
All tests passed.
roger@MacBook-Pro node-contribute % uname -a
Darwin MacBook-Pro.local 21.6.0 Darwin Kernel Version 21.6.0: Wed Aug 10 14:25:27 PDT 2022; root:xnu-8020.141.5~2/RELEASE_X86_64 x86_64
roger@MacBook-Pro node-contribute % |
Member
|
I think 50ms too would not be bad, just did some preliminary check it passed the stress test at 50 too, just want to optimise for the lowest number for which this wouldnt be flaky |
Member
|
I think this is no longer needed. The stress test passes on my mac. |
2 tasks
Contributor
|
This is still required. I just hit this failure when building on Linux. |
Contributor
|
See my PR #55959 for a more robust alternative. |
Contributor
|
This can be closed now that my PR is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a passive closing socket, wait 100 ms for it to be closed.
Fix #47200