Merged
Conversation
Collaborator
|
Review requested:
|
Contributor
|
Pinging @fasenderos since they are the one who drove the zlib upgrade changes, and the diff looks a bit weird. |
Contributor
|
@aduh95 I'll take a look |
Contributor
|
The changes of this PR reflect the Chromium's copy of zlib that we use (we don't use the official zlib library): |
Member
|
More specifically, the license header was changed in https://chromium.googlesource.com/chromium/src/+/f103edb8dc89fd780cd374ca34707617f49d0303%5E%21/#F10 |
aduh95
approved these changes
Jun 6, 2023
RafaelGSS
approved these changes
Jun 6, 2023
Member
RafaelGSS
left a comment
There was a problem hiding this comment.
Thanks for checking it @fasenderos @targos. LGTM.
aymen94
approved these changes
Jun 6, 2023
lpinca
approved these changes
Jun 6, 2023
Collaborator
|
Landed in f100732 |
RafaelGSS
pushed a commit
that referenced
this pull request
Jul 3, 2023
PR-URL: #48336 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
PR-URL: nodejs#48336 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
PR-URL: nodejs#48336 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
ruyadorno
pushed a commit
that referenced
this pull request
Aug 29, 2023
PR-URL: #48336 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
License is likely out of date. This is an automatically generated PR by the
license-builder.ymlGitHub Action, which runslicense-builder.shand submits a new PR or updates an existing PR.