tools: fix github reporter appended multiple times#49199
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Aug 16, 2023
Merged
tools: fix github reporter appended multiple times#49199nodejs-github-bot merged 1 commit intonodejs:mainfrom
nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
Contributor
|
Fast-track has been requested by @MoLow. Please 👍 to approve. |
atlowChemi
approved these changes
Aug 16, 2023
benjamingr
approved these changes
Aug 16, 2023
Collaborator
|
Landed in e2d666d |
UlisesGascon
pushed a commit
that referenced
this pull request
Sep 10, 2023
PR-URL: #49199 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a follow-up for #49129
since
additional_flagswas shared between all tests the reporter kept being added again for each test.see for example https://github.com/nodejs/node/actions/runs/5870373336/job/15917272924?pr=49184