Closed
Conversation
Collaborator
|
Review requested:
|
bnoordhuis
reviewed
Aug 26, 2023
src/node_url.cc
Outdated
| if (input.empty()) { | ||
| return args.GetReturnValue().Set( | ||
| String::NewFromUtf8(env->isolate(), "").ToLocalChecked()); | ||
| return args.GetReturnValue().Set(FIXED_ONE_BYTE_STRING(env->isolate(), "")); |
Member
There was a problem hiding this comment.
Suggested change
| return args.GetReturnValue().Set(FIXED_ONE_BYTE_STRING(env->isolate(), "")); | |
| return args.GetReturnValue().Set(String::Empty(env->isolate())); |
Contributor
Author
There was a problem hiding this comment.
@bnoordhuis Thanks for the comment.
The current file also has code that uses the same.
It also has been fixed.
I would appreciate it if you could take a look if you have time.
anonrig
approved these changes
Aug 27, 2023
bnoordhuis
approved these changes
Aug 27, 2023
RaisinTen
approved these changes
Aug 28, 2023
lpinca
approved these changes
Aug 28, 2023
Collaborator
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/49336 ✔ Done loading data for nodejs/node/pull/49336 ----------------------------------- PR info ------------------------------------ Title src: modify code for empty string (#49336) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch pluris:fix/apply_comment_49097 -> nodejs:main Labels c++, whatwg-url, author ready, needs-ci Commits 2 - src: change String::NewFromUtf8 to FIXED_ONE_BYTE_STRING - src: modify code for empty string Committers 1 - pluris PR-URL: https://github.com/nodejs/node/pull/49336 Refs: https://github.com/nodejs/node/pull/49097 Reviewed-By: Yagiz Nizipli Reviewed-By: Ben Noordhuis Reviewed-By: Darshan Sen Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/49336 Refs: https://github.com/nodejs/node/pull/49097 Reviewed-By: Yagiz Nizipli Reviewed-By: Ben Noordhuis Reviewed-By: Darshan Sen Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 26 Aug 2023 17:05:16 GMT ✔ Approvals: 4 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/49336#pullrequestreview-1597142973 ✔ - Ben Noordhuis (@bnoordhuis) (TSC): https://github.com/nodejs/node/pull/49336#pullrequestreview-1597169599 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/49336#pullrequestreview-1598057869 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/49336#pullrequestreview-1598897036 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-08-29T22:12:22Z: https://ci.nodejs.org/job/node-test-pull-request/53629/ - Querying data for job/node-test-pull-request/53629/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 49336 From https://github.com/nodejs/node * branch refs/pull/49336/merge -> FETCH_HEAD ✔ Fetched commits as 048e0bec5147..82f6e1efc6b7 -------------------------------------------------------------------------------- Auto-merging src/node_url.cc [main aec94eaba5] src: change String::NewFromUtf8 to FIXED_ONE_BYTE_STRING Author: pluris Date: Sun Aug 27 02:00:03 2023 +0900 1 file changed, 1 insertion(+), 2 deletions(-) Auto-merging src/node_url.cc [main def2c58919] src: modify code for empty string Author: pluris Date: Sun Aug 27 22:53:48 2023 +0900 1 file changed, 4 insertions(+), 5 deletions(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)https://github.com/nodejs/node/actions/runs/6046507005 |
82f6e1e to
a0bd32a
Compare
Contributor
Author
|
A commit queue failed, so I made 2 commits into 1. |
Member
|
So sorry should have used the squash label! landing this manually |
debadree25
approved these changes
Sep 1, 2023
Member
|
Landed in ce11e00 |
Merged
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
PR-URL: nodejs#49336 Refs: nodejs#49097 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a part that did not apply in the comment, so it was modified.
I fixed the handling of empty string.
https://github.com/nodejs/node/pull/49097/files#r1291579651
Refs: #49097