test: add test for urlstrings usage in node:fs#49471
Merged
nodejs-github-bot merged 3 commits intonodejs:mainfrom Sep 5, 2023
Merged
test: add test for urlstrings usage in node:fs#49471nodejs-github-bot merged 3 commits intonodejs:mainfrom
node:fs#49471nodejs-github-bot merged 3 commits intonodejs:mainfrom
Conversation
Collaborator
aduh95
approved these changes
Sep 3, 2023
test/parallel/test-fs-whatwg-url.js
Outdated
Comment on lines
86
to
88
| // Test that strings are interpreted as paths and not as URL | ||
| // Please avoid testing fs.rmdir('file:') or using it as cleanup | ||
| if (!common.isWindows) { |
Contributor
There was a problem hiding this comment.
nit: should we put it in the else block just above?
This was referenced Sep 4, 2023
Collaborator
Collaborator
lpinca
approved these changes
Sep 5, 2023
Collaborator
|
Landed in 21759bd |
This was referenced Sep 6, 2023
ruyadorno
pushed a commit
that referenced
this pull request
Sep 28, 2023
PR-URL: #49471 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
PR-URL: nodejs#49471 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.