bootstrap: use internal.url instead of url#49649
Closed
LiviaMedeiros wants to merge 1 commit intonodejs:mainfrom
Closed
bootstrap: use internal.url instead of url#49649LiviaMedeiros wants to merge 1 commit intonodejs:mainfrom
internal.url instead of url#49649LiviaMedeiros wants to merge 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
Member
|
I think we should keep it. The reason why it's here is to include |
Member
Author
|
Is there performance difference between importing it unconditionally here, and explicit import in user-provided snapshot code? |
Contributor
What do you mean "popular module"? I think the goal is to bootstrap all the builtin modules so they're in the snapshot, unfortunately not all of them are snapshotable. |
Member
Author
|
Ah, I was under impression from that we only pre-require modules that are necessary for loading process that happens in 100% cases.If we want to include all possible builtins in snapshot, it indeed must stay. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #49590 (comment)
Not sure if it might break any binary compatibility that would cause high semverness, or cause any significant regression.
cc @nodejs/process