test: fix crypto-dh error message for OpenSSL 3.x by krk · Pull Request #50395 · nodejs/node

krk · 2023-10-25T17:50:58Z

OpenSSL 3.0.12 and 3.1.4 changes the type of error short keys and IVs cause.

Error message change is test-only and uses the right error message for versions >= 3.0.12 in 3.0.x and >= 3.1.4 in 3.1.x series.

With these changes to OpenSSL, error message in XX test is now 'Supplied key is too small' instead of 'error:02800080:Diffie-Hellman routines::invalid secret'.

--

Sample failure:

Path: parallel/test-crypto-dh
node:assert:635
      throw err;
      ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
+ actual - expected

  Comparison {
+   message: 'Supplied key is too small'
-   message: 'error:02800080:Diffie-Hellman routines::invalid secret'
  }
    at Object.<anonymous> (/src/node-v20.8.1/test/parallel/test-crypto-dh.js:88:10)
    at Module._compile (node:internal/modules/cjs/loader:1241:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1295:10)
    at Module.load (node:internal/modules/cjs/loader:1091:32)
    at Module._load (node:internal/modules/cjs/loader:938:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:83:12)
    at node:internal/main/run_main_module:23:47 {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: RangeError: Supplied key is too small
      at DiffieHellman.dhComputeSecret [as computeSecret] (node:internal/crypto/diffiehellman:156:29)
      at assert.throws.message (/src/node-v20.8.1/test/parallel/test-crypto-dh.js:89:9)
      at getActual (node:assert:756:5)
      at Function.throws (node:assert:902:24)
      at Object.<anonymous> (/src/node-v20.8.1/test/parallel/test-crypto-dh.js:88:10)
      at Module._compile (node:internal/modules/cjs/loader:1241:14)
      at Module._extensions..js (node:internal/modules/cjs/loader:1295:10)
      at Module.load (node:internal/modules/cjs/loader:1091:32)
      at Module._load (node:internal/modules/cjs/loader:938:12)
      at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:83:12) {
    code: 'ERR_CRYPTO_INVALID_KEYLEN'
  },
  expected: { message: 'error:02800080:Diffie-Hellman routines::invalid secret' },
  operator: 'throws'
}

OpenSSL 3.0.12 and 3.1.4 changes the type of error short keys and IVs cause. The error message in test-crypto-dh for the "empty secret" is now 'Supplied key is too small' instead of 'error:02800080:Diffie-Hellman routines::invalid secret'. Error message change is test-only and uses the right error message for versions >=3.0.12 in 3.0.x and >= 3.1.4 in 3.1.x series. ref. https://git.openssl.org/gitweb/?p=openssl.git;a=commitdiff;h=0df40630850fb2740e6be6890bb905d3fc623b2d ref. https://git.openssl.org/gitweb/?p=openssl.git;a=commitdiff;h=5f69f5c65e483928c4b28ed16af6e5742929f1ee ref. https://www.openssl.org/news/vulnerabilities.html#CVE-2023-5363

test/parallel/test-crypto-dh.js

richardlau · 2023-10-26T17:17:44Z

The https://ci.nodejs.org/job/node-test-commit-linux-containered/nodes=ubuntu1804_sharedlibs_withoutintl_x64/40113/ failure is #49988 (comment) and unrelated to this PR. Once we fix that, requesting a new Jenkins CI run should pick up the change.

nodejs-github-bot · 2023-10-26T20:59:16Z

CI: https://ci.nodejs.org/job/node-test-pull-request/55261/

nodejs-github-bot · 2023-10-26T23:53:55Z

CI: https://ci.nodejs.org/job/node-test-pull-request/55262/

nodejs-github-bot · 2023-10-27T18:01:12Z

Landed in 8eea2d3

OpenSSL 3.0.12 and 3.1.4 changes the type of error short keys and IVs cause. The error message in test-crypto-dh for the "empty secret" is now 'Supplied key is too small' instead of 'error:02800080:Diffie-Hellman routines::invalid secret'. Error message change is test-only and uses the right error message for versions >=3.0.12 in 3.0.x and >= 3.1.4 in 3.1.x series. ref. https://git.openssl.org/gitweb/?p=openssl.git;a=commitdiff;h=0df40630850fb2740e6be6890bb905d3fc623b2d ref. https://git.openssl.org/gitweb/?p=openssl.git;a=commitdiff;h=5f69f5c65e483928c4b28ed16af6e5742929f1ee ref. https://www.openssl.org/news/vulnerabilities.html#CVE-2023-5363 PR-URL: nodejs#50395 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

OpenSSL 3.0.12 and 3.1.4 changes the type of error short keys and IVs cause. The error message in test-crypto-dh for the "empty secret" is now 'Supplied key is too small' instead of 'error:02800080:Diffie-Hellman routines::invalid secret'. Error message change is test-only and uses the right error message for versions >=3.0.12 in 3.0.x and >= 3.1.4 in 3.1.x series. ref. https://git.openssl.org/gitweb/?p=openssl.git;a=commitdiff;h=0df40630850fb2740e6be6890bb905d3fc623b2d ref. https://git.openssl.org/gitweb/?p=openssl.git;a=commitdiff;h=5f69f5c65e483928c4b28ed16af6e5742929f1ee ref. https://www.openssl.org/news/vulnerabilities.html#CVE-2023-5363 PR-URL: #50395 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Ref: nodejs/node#50395 Ref: https://bugs.debian.org/1055416 Ref: deepin-community/sig-deepin-sysdev-team#536

OpenSSL 3.0.12 and 3.1.4 changes the type of error short keys and IVs cause. The error message in test-crypto-dh for the "empty secret" is now 'Supplied key is too small' instead of 'error:02800080:Diffie-Hellman routines::invalid secret'. Error message change is test-only and uses the right error message for versions >=3.0.12 in 3.0.x and >= 3.1.4 in 3.1.x series. ref. https://git.openssl.org/gitweb/?p=openssl.git;a=commitdiff;h=0df40630850fb2740e6be6890bb905d3fc623b2d ref. https://git.openssl.org/gitweb/?p=openssl.git;a=commitdiff;h=5f69f5c65e483928c4b28ed16af6e5742929f1ee ref. https://www.openssl.org/news/vulnerabilities.html#CVE-2023-5363 PR-URL: #50395 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

OpenSSL 3.0.12 and 3.1.4 changes the type of error short keys and IVs cause. The error message in test-crypto-dh for the "empty secret" is now 'Supplied key is too small' instead of 'error:02800080:Diffie-Hellman routines::invalid secret'. Error message change is test-only and uses the right error message for versions >=3.0.12 in 3.0.x and >= 3.1.4 in 3.1.x series. ref. https://git.openssl.org/gitweb/?p=openssl.git;a=commitdiff;h=0df40630850fb2740e6be6890bb905d3fc623b2d ref. https://git.openssl.org/gitweb/?p=openssl.git;a=commitdiff;h=5f69f5c65e483928c4b28ed16af6e5742929f1ee ref. https://www.openssl.org/news/vulnerabilities.html#CVE-2023-5363 PR-URL: nodejs/node#50395 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

As per the original pull request that introduced the OpenSSL version check in `parallel/test-crypto-dh`: ``` Error message change is test-only and uses the right error message for versions >=3.0.12 in 3.0.x and >= 3.1.4 in 3.1.x series. ``` Fix the check so that: - The older message is expected for OpenSSL 3.1.0. - The newer message is expected for OpenSSL from 3.1.4 (e.g. 3.2.x). Refs: nodejs#50395

As per the original pull request that introduced the OpenSSL version check in `parallel/test-crypto-dh`: ``` Error message change is test-only and uses the right error message for versions >=3.0.12 in 3.0.x and >= 3.1.4 in 3.1.x series. ``` Fix the check so that: - The older message is expected for OpenSSL 3.1.0. - The newer message is expected for OpenSSL from 3.1.4 (e.g. 3.2.x). Refs: #50395 PR-URL: #53503 Refs: #53382 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

As per the original pull request that introduced the OpenSSL version check in `parallel/test-crypto-dh`: ``` Error message change is test-only and uses the right error message for versions >=3.0.12 in 3.0.x and >= 3.1.4 in 3.1.x series. ``` Fix the check so that: - The older message is expected for OpenSSL 3.1.0. - The newer message is expected for OpenSSL from 3.1.4 (e.g. 3.2.x). Refs: nodejs#50395 PR-URL: nodejs#53503 Refs: nodejs#53382 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 25, 2023

richardlau mentioned this pull request Oct 26, 2023

deps: update OpenSSL to 3.0.12+quic1 #50411

Closed

richardlau approved these changes Oct 26, 2023

View reviewed changes

test/parallel/test-crypto-dh.js Show resolved Hide resolved

richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 26, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 26, 2023

This comment was marked as outdated.

Sign in to view

lpinca approved these changes Oct 26, 2023

View reviewed changes

richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 26, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 26, 2023

tniessen added crypto Issues and PRs related to the crypto subsystem. openssl Issues and PRs related to the OpenSSL dependency. labels Oct 26, 2023

richardlau added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 26, 2023

github-actions bot mentioned this pull request Oct 27, 2023

CI Reliability 2023-10-27 nodejs/reliability#699

Open

19 tasks

richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 27, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 27, 2023

nodejs-github-bot merged commit 8eea2d3 into nodejs:main Oct 27, 2023

This was referenced Oct 28, 2023

CI Reliability 2023-10-28 nodejs/reliability#700

Open

CI Reliability 2023-10-29 nodejs/reliability#701

Open

CI Reliability 2023-10-30 nodejs/reliability#702

Open

CI Reliability 2023-10-31 nodejs/reliability#703

Open

richardlau added lts-watch-v18.x lts-watch-v20.x PRs that may need to be released in v20.x labels Nov 1, 2023

targos mentioned this pull request Nov 12, 2023

v21.2.0 release proposal #50681

Merged

UTsweetyfish mentioned this pull request Nov 15, 2023

nodejs 18.13.0+dfsg1-1 FTBFS with openssl 3.0.12 deepin-community/sig-deepin-sysdev-team#536

Closed

UTsweetyfish added a commit to UTsweetyfish/nodejs that referenced this pull request Nov 15, 2023

Fix FTBFS with openssl 3.0.12

2eed27e

Ref: nodejs/node#50395 Ref: https://bugs.debian.org/1055416 Ref: deepin-community/sig-deepin-sysdev-team#536

UTsweetyfish mentioned this pull request Nov 15, 2023

Fix FTBFS with openssl 3.0.12 deepin-community/nodejs#2

Merged

deepin-ci-robot pushed a commit to deepin-community/nodejs that referenced this pull request Nov 15, 2023

Fix FTBFS with openssl 3.0.12

2d5bbc7

Ref: nodejs/node#50395 Ref: https://bugs.debian.org/1055416 Ref: deepin-community/sig-deepin-sysdev-team#536

targos added backported-to-v20.x PRs backported to the v20.x-staging branch. and removed lts-watch-v20.x PRs that may need to be released in v20.x labels Nov 15, 2023

targos added backported-to-v18.x and removed lts-watch-v18.x labels Nov 15, 2023

targos mentioned this pull request Nov 21, 2023

v20.10.0 release proposal #50682

Merged

targos mentioned this pull request Nov 28, 2023

v18.19.0 release proposal #50953

Merged

juanarbol mentioned this pull request Dec 6, 2023

2023-12-06, N|Solid v5.0.1 Iron Release nodesource/nsolid#41

Merged

richardlau mentioned this pull request Jun 14, 2024

src: fix dynamically linked OpenSSL version #53456

Closed

richardlau mentioned this pull request Jun 18, 2024

test: fix OpenSSL version checks #53503

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test: fix crypto-dh error message for OpenSSL 3.x#50395

test: fix crypto-dh error message for OpenSSL 3.x#50395
nodejs-github-bot merged 1 commit intonodejs:mainfrom
krk:fix-dh-error-message

krk commented Oct 25, 2023

Uh oh!

Uh oh!

This comment was marked as outdated.

richardlau commented Oct 26, 2023

Uh oh!

nodejs-github-bot commented Oct 26, 2023

Uh oh!

nodejs-github-bot commented Oct 26, 2023

Uh oh!

nodejs-github-bot commented Oct 27, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

krk commented Oct 25, 2023

Uh oh!

Uh oh!

This comment was marked as outdated.

richardlau commented Oct 26, 2023

Uh oh!

nodejs-github-bot commented Oct 26, 2023

Uh oh!

nodejs-github-bot commented Oct 26, 2023

Uh oh!

nodejs-github-bot commented Oct 27, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants