Closed
Conversation
Collaborator
|
Review requested:
|
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Oct 28, 2023
No longer necessary given recent stream and event optimziations. Refs: nodejs#50428 Refs: nodejs#50439 PR-URL: nodejs#50440
9bf65a3 to
efdea70
Compare
Member
Author
|
Waiting for #50428 which reduces the overhead of registering the |
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Oct 28, 2023
No longer necessary given recent stream and event optimziations. Refs: nodejs#50428 Refs: nodejs#50439 PR-URL: nodejs#50440
efdea70 to
5fe2816
Compare
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Oct 28, 2023
No longer necessary given recent stream and event optimziations. Refs: nodejs#50428 Refs: nodejs#50439 PR-URL: nodejs#50440
5fe2816 to
d9f2770
Compare
jasnell
approved these changes
Oct 28, 2023
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Oct 29, 2023
No longer necessary given recent stream and event optimziations. Refs: nodejs#50428 Refs: nodejs#50439 PR-URL: nodejs#50440
d9f2770 to
06c89b4
Compare
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Oct 29, 2023
No longer necessary given recent stream and event optimziations. Refs: nodejs#50428 Refs: nodejs#50439 PR-URL: nodejs#50440
06c89b4 to
2bad63b
Compare
Collaborator
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Oct 29, 2023
No longer necessary given recent stream and event optimziations. Refs: nodejs#50428 Refs: nodejs#50439 PR-URL: nodejs#50440
2bad63b to
3bab912
Compare
25 tasks
Member
|
It doesn't seem like that's the case, benchmark results: |
Member
Author
|
Hm, yea, that's unfortunate |
Member
Author
|
Strangely enough the benchmark I added is actually "faster": |
No longer necessary given recent stream and event optimziations. Refs: nodejs#50428 Refs: nodejs#50439 PR-URL: nodejs#50440
3bab912 to
c249549
Compare
Member
Author
|
The legacy api doesn't need the readable side. Which is why this will never be fast enough. |
This was referenced Oct 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No longer necessary given recent stream and event optimziations.
Refs: #50428
Refs: #50439