Skip to content

test: fix test runner colored output test#51064

Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom
MoLow:fix-test-runner-colors-test
Dec 10, 2023
Merged

test: fix test runner colored output test#51064
nodejs-github-bot merged 1 commit intonodejs:mainfrom
MoLow:fix-test-runner-colors-test

Conversation

@MoLow
Copy link
Member

@MoLow MoLow commented Dec 5, 2023

this test should have caught a bug introduced in #50982 (review)
this causes the test to catch such bugs

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Dec 5, 2023
rluvaton
rluvaton reviewed Dec 5, 2023
View reviewed changes
Copy link
Member

@rluvaton rluvaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you need to update the snapshot as well?

@MoLow
Copy link
Member Author

MoLow commented Dec 5, 2023

CC @pulkit-30

@MoLow
Copy link
Member Author

MoLow commented Dec 5, 2023 •
edited
Loading

Don't you need to update the snapshot as well?

the snapshot is correct, FORCE_COLOR is passed by

node/lib/internal/test_runner/runner.js

Lines 329 to 331 in ab857e1

if (opts.root.harness.shouldColorizeTestFiles) {
env.FORCE_COLOR = '1';
}

which was attempted to be affected by #50982

@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 5, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 5, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 5, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/56116/

@pulkit-30 pulkit-30 mentioned this pull request Dec 6, 2023
Merged
@MoLow MoLow force-pushed the fix-test-runner-colors-test branch from 9f54bab to 85b2070 Compare December 6, 2023 07:01
@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 6, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 6, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 6, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/56126/

@MoLow MoLow force-pushed the fix-test-runner-colors-test branch 3 times, most recently from d001c60 to 64b76e1 Compare December 6, 2023 17:32
@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 6, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 6, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 6, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/56135/

@MoLow MoLow force-pushed the fix-test-runner-colors-test branch from 64b76e1 to 764ba19 Compare December 7, 2023 20:45
@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 7, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 7, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 7, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/56157/

@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 8, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 8, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 8, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/56158/

@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 8, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 8, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 8, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/56159/

@MoLow MoLow force-pushed the fix-test-runner-colors-test branch from 1d5f540 to 3c78ee4 Compare December 8, 2023 08:53
@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 8, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 8, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 8, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/56161/

@MoLow MoLow force-pushed the fix-test-runner-colors-test branch from 3c78ee4 to 4dacfb7 Compare December 8, 2023 09:22
@MoLow MoLow added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Dec 8, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 8, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/56164/

@MoLow MoLow requested a review from rluvaton December 8, 2023 10:32
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 8, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/56166/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 10, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/56189/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 10, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/56192/

@MoLow MoLow added commit-queue Add this label to land a pull request using GitHub Actions. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Dec 10, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 10, 2023
@nodejs-github-bot nodejs-github-bot merged commit cb08703 into nodejs:main Dec 10, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 10, 2023

Landed in cb08703

@MoLow MoLow deleted the fix-test-runner-colors-test branch December 10, 2023 07:46
RafaelGSS pushed a commit that referenced this pull request Dec 15, 2023
@MoLow @RafaelGSS
test: fix test runner colored output test
048349e 
PR-URL: #51064
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Dec 15, 2023
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@MoLow @richardlau
test: fix test runner colored output test
9f88f40 
PR-URL: #51064
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@benjamingr benjamingr benjamingr approved these changes

@atlowChemi atlowChemi atlowChemi approved these changes

@rluvaton rluvaton Awaiting requested review from rluvaton

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@MoLow @nodejs-github-bot @jasnell @benjamingr @rluvaton @atlowChemi