doc: add Paolo to TSC members by mhdawson · Pull Request #51825 · nodejs/node

mhdawson · 2024-02-21T17:01:07Z

Refs: nodejs/TSC#1501

Refs: nodejs/TSC#1501 Signed-off-by: Michael Dawson <midawson@redhat.com>

mhdawson · 2024-02-21T17:02:00Z

@ShogunPanda welcome !

ShogunPanda · 2024-02-21T17:03:49Z

Thank you a very lot! It's a huge honor!

ShogunPanda

Proudly LGTM!

README.md

github-actions · 2024-02-21T19:30:51Z

Fast-track has been requested by @mhdawson. Please 👍 to approve.

nodejs-github-bot · 2024-02-21T19:34:00Z

Commit Queue failed

- Loading data for nodejs/node/pull/51825
✔  Done loading data for nodejs/node/pull/51825
----------------------------------- PR info ------------------------------------
Title      doc: add Paolo to TSC members (#51825)
Author     Michael Dawson  (@mhdawson)
Branch     mhdawson:addPaolo -> nodejs:main
Labels     doc, fast-track, author ready
Commits    3
 - doc: add Paolo to TSC members
 - fix alphabetization
 - remove extra space
Committers 2
 - Michael Dawson 
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/51825
Refs: https://github.com/nodejs/TSC/issues/1501
Reviewed-By: Paolo Insogna 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Yagiz Nizipli 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/51825
Refs: https://github.com/nodejs/TSC/issues/1501
Reviewed-By: Paolo Insogna 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Yagiz Nizipli 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 21 Feb 2024 17:01:07 GMT
   ✔  Approvals: 3
   ✔  - Paolo Insogna (@ShogunPanda): https://github.com/nodejs/node/pull/51825#pullrequestreview-1893861202
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/51825#pullrequestreview-1894019219
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/51825#pullrequestreview-1894188370
   ℹ  This PR is being fast-tracked
   ✘  This PR needs to wait 45 more hours to land (or 0 hours if there are 2 more approvals (👍) of the fast-track request from collaborators).
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/7994538952

nodejs-github-bot · 2024-02-21T22:05:44Z

Commit Queue failed

- Loading data for nodejs/node/pull/51825 ✔ Done loading data for nodejs/node/pull/51825 ----------------------------------- PR info ------------------------------------ Title doc: add Paolo to TSC members (#51825) Author Michael Dawson (@mhdawson) Branch mhdawson:addPaolo -> nodejs:main Labels doc, fast-track, author ready Commits 3 - doc: add Paolo to TSC members - fix alphabetization - remove extra space Committers 2 - Michael Dawson - GitHub PR-URL: https://github.com/nodejs/node/pull/51825 Refs: https://github.com/nodejs/TSC/issues/1501 Reviewed-By: Paolo Insogna Reviewed-By: Antoine du Hamel Reviewed-By: Yagiz Nizipli Reviewed-By: Vinícius Lourenço Claro Cardoso ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/51825 Refs: https://github.com/nodejs/TSC/issues/1501 Reviewed-By: Paolo Insogna Reviewed-By: Antoine du Hamel Reviewed-By: Yagiz Nizipli Reviewed-By: Vinícius Lourenço Claro Cardoso -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 21 Feb 2024 17:01:07 GMT ✔ Approvals: 4 ✔ - Paolo Insogna (@ShogunPanda): https://github.com/nodejs/node/pull/51825#pullrequestreview-1893861202 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/51825#pullrequestreview-1894019219 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/51825#pullrequestreview-1894188370 ✔ - Vinícius Lourenço Claro Cardoso (@H4ad): https://github.com/nodejs/node/pull/51825#pullrequestreview-1894483078 ℹ This PR is being fast-tracked ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 51825 From https://github.com/nodejs/node * branch refs/pull/51825/merge -> FETCH_HEAD ✔ Fetched commits as a0ac8bd4d85e..f048ea69ee1f -------------------------------------------------------------------------------- [main 31f88deb16] doc: add Paolo to TSC members Author: Michael Dawson Date: Wed Feb 21 16:59:33 2024 +0000 1 file changed, 2 insertions(+) [main 2106ddb1dd] fix alphabetization Author: Michael Dawson Date: Wed Feb 21 12:45:17 2024 -0500 1 file changed, 3 insertions(+), 2 deletions(-) [main 4217070a4d] remove extra space Author: Michael Dawson Date: Wed Feb 21 12:46:10 2024 -0500 1 file changed, 1 deletion(-) ✔ Patches applied There are 3 commits in the PR. Attempting autorebase. Rebasing (2/6)

Executing: git node land --amend --yes
⚠ Found Refs: nodejs/TSC#1501, skipping..
--------------------------------- New Message ----------------------------------
doc: add Paolo to TSC members

Refs: nodejs/TSC#1501

Signed-off-by: Michael Dawson midawson@redhat.com
PR-URL: #51825
Reviewed-By: Paolo Insogna paolo@cowtech.it
Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com
Reviewed-By: Yagiz Nizipli yagiz.nizipli@sentry.io
Reviewed-By: Vinícius Lourenço Claro Cardoso contact@viniciusl.com.br

[detached HEAD 9c5541ff79] doc: add Paolo to TSC members
Author: Michael Dawson midawson@redhat.com
Date: Wed Feb 21 16:59:33 2024 +0000
1 file changed, 2 insertions(+)
Rebasing (3/6)
Rebasing (4/6)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
fix alphabetization

PR-URL: #51825
Refs: nodejs/TSC#1501
Reviewed-By: Paolo Insogna paolo@cowtech.it
Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com
Reviewed-By: Yagiz Nizipli yagiz.nizipli@sentry.io
Reviewed-By: Vinícius Lourenço Claro Cardoso contact@viniciusl.com.br

[detached HEAD 250c5d8546] fix alphabetization
Author: Michael Dawson mdawson@devrus.com
Date: Wed Feb 21 12:45:17 2024 -0500
1 file changed, 3 insertions(+), 2 deletions(-)
Rebasing (5/6)
Rebasing (6/6)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
remove extra space

PR-URL: #51825
Refs: nodejs/TSC#1501
Reviewed-By: Paolo Insogna paolo@cowtech.it
Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com
Reviewed-By: Yagiz Nizipli yagiz.nizipli@sentry.io
Reviewed-By: Vinícius Lourenço Claro Cardoso contact@viniciusl.com.br

[detached HEAD bf251ed559] remove extra space
Author: Michael Dawson mdawson@devrus.com
Date: Wed Feb 21 12:46:10 2024 -0500
1 file changed, 1 deletion(-)

Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/7996169474

nodejs-github-bot · 2024-02-21T22:27:01Z

Landed in 5dfff3a

Refs: nodejs/TSC#1501 Signed-off-by: Michael Dawson <midawson@redhat.com> PR-URL: #51825 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>

Refs: nodejs/TSC#1501 Signed-off-by: Michael Dawson <midawson@redhat.com> PR-URL: nodejs#51825 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>

doc: add Paolo to TSC members

5706511

Refs: nodejs/TSC#1501 Signed-off-by: Michael Dawson <midawson@redhat.com>

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 21, 2024

mhdawson mentioned this pull request Feb 21, 2024

Nominating @ShogunPanda nodejs/TSC#1501

Closed

ShogunPanda approved these changes Feb 21, 2024

View reviewed changes

aduh95 reviewed Feb 21, 2024

View reviewed changes

README.md Outdated Show resolved Hide resolved

mhdawson added 2 commits February 21, 2024 12:45

fix alphabetization

a32d3a5

remove extra space

f048ea6

aduh95 approved these changes Feb 21, 2024

View reviewed changes

aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 21, 2024

anonrig approved these changes Feb 21, 2024

View reviewed changes

mhdawson added the fast-track PRs that do not need to wait for 72 hours to land. label Feb 21, 2024

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 21, 2024

H4ad approved these changes Feb 21, 2024

View reviewed changes

aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Feb 21, 2024

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 21, 2024

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 21, 2024

nodejs-github-bot merged commit 5dfff3a into nodejs:main Feb 21, 2024

marco-ippolito mentioned this pull request Mar 1, 2024

v21.7.0 proposal #51932

Merged

richardlau mentioned this pull request Mar 25, 2024

v20.12.0 proposal #52212

Merged

RafaelGSS mentioned this pull request May 15, 2024

Nominating @marco-ippolito to TSC nodejs/TSC#1550

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

doc: add Paolo to TSC members#51825

doc: add Paolo to TSC members#51825
nodejs-github-bot merged 3 commits intonodejs:mainfrom
mhdawson:addPaolo

mhdawson commented Feb 21, 2024

Uh oh!

mhdawson commented Feb 21, 2024

Uh oh!

ShogunPanda commented Feb 21, 2024

Uh oh!

ShogunPanda left a comment

Uh oh!

Uh oh!

github-actions bot commented Feb 21, 2024

Uh oh!

nodejs-github-bot commented Feb 21, 2024

Uh oh!

nodejs-github-bot commented Feb 21, 2024

Signed-off-by: Michael Dawson midawson@redhat.com
PR-URL: #51825
Reviewed-By: Paolo Insogna paolo@cowtech.it
Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com
Reviewed-By: Yagiz Nizipli yagiz.nizipli@sentry.io
Reviewed-By: Vinícius Lourenço Claro Cardoso contact@viniciusl.com.br

PR-URL: #51825
Refs: nodejs/TSC#1501
Reviewed-By: Paolo Insogna paolo@cowtech.it
Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com
Reviewed-By: Yagiz Nizipli yagiz.nizipli@sentry.io
Reviewed-By: Vinícius Lourenço Claro Cardoso contact@viniciusl.com.br

PR-URL: #51825
Refs: nodejs/TSC#1501
Reviewed-By: Paolo Insogna paolo@cowtech.it
Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com
Reviewed-By: Yagiz Nizipli yagiz.nizipli@sentry.io
Reviewed-By: Vinícius Lourenço Claro Cardoso contact@viniciusl.com.br

Successfully rebased and updated refs/heads/main.

Uh oh!

nodejs-github-bot commented Feb 21, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

mhdawson commented Feb 21, 2024

Uh oh!

mhdawson commented Feb 21, 2024

Uh oh!

ShogunPanda commented Feb 21, 2024

Uh oh!

ShogunPanda left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Feb 21, 2024

Uh oh!

nodejs-github-bot commented Feb 21, 2024

Uh oh!

nodejs-github-bot commented Feb 21, 2024

Signed-off-by: Michael Dawson midawson@redhat.com PR-URL: #51825 Reviewed-By: Paolo Insogna paolo@cowtech.it Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com Reviewed-By: Yagiz Nizipli yagiz.nizipli@sentry.io Reviewed-By: Vinícius Lourenço Claro Cardoso contact@viniciusl.com.br

PR-URL: #51825 Refs: nodejs/TSC#1501 Reviewed-By: Paolo Insogna paolo@cowtech.it Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com Reviewed-By: Yagiz Nizipli yagiz.nizipli@sentry.io Reviewed-By: Vinícius Lourenço Claro Cardoso contact@viniciusl.com.br

PR-URL: #51825 Refs: nodejs/TSC#1501 Reviewed-By: Paolo Insogna paolo@cowtech.it Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com Reviewed-By: Yagiz Nizipli yagiz.nizipli@sentry.io Reviewed-By: Vinícius Lourenço Claro Cardoso contact@viniciusl.com.br

Successfully rebased and updated refs/heads/main.

Uh oh!

nodejs-github-bot commented Feb 21, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Signed-off-by: Michael Dawson midawson@redhat.com
PR-URL: #51825
Reviewed-By: Paolo Insogna paolo@cowtech.it
Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com
Reviewed-By: Yagiz Nizipli yagiz.nizipli@sentry.io
Reviewed-By: Vinícius Lourenço Claro Cardoso contact@viniciusl.com.br

PR-URL: #51825
Refs: nodejs/TSC#1501
Reviewed-By: Paolo Insogna paolo@cowtech.it
Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com
Reviewed-By: Yagiz Nizipli yagiz.nizipli@sentry.io
Reviewed-By: Vinícius Lourenço Claro Cardoso contact@viniciusl.com.br

PR-URL: #51825
Refs: nodejs/TSC#1501
Reviewed-By: Paolo Insogna paolo@cowtech.it
Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com
Reviewed-By: Yagiz Nizipli yagiz.nizipli@sentry.io
Reviewed-By: Vinícius Lourenço Claro Cardoso contact@viniciusl.com.br