src: remove regex usage for env file parsing#52406
Merged
nodejs-github-bot merged 2 commits intonodejs:mainfrom Apr 17, 2024
Merged
src: remove regex usage for env file parsing#52406nodejs-github-bot merged 2 commits intonodejs:mainfrom
nodejs-github-bot merged 2 commits intonodejs:mainfrom
Conversation
climba03003
reviewed
Apr 7, 2024
Contributor
climba03003
left a comment
There was a problem hiding this comment.
Can you add multiple continues comments in valid.env to ensure it works?
Member
Author
@climba03003 Could you provide me with an example and the expected result? |
Contributor
// .valid.env
#COMMENTED_ENV=should not shown
#COMMENTED_ENV_FOLLOW_COMMENTED_ENV=should not shown
#COMMENTED_ENV_FOLLOW_COMMENTED_ENV_2=should not shown
// test
// Commented environment should be undefined
assert.strictEqual(process.env.COMMENTED_ENV, undefined);
assert.strictEqual(process.env.COMMENTED_ENV_FOLLOW_COMMENTED_ENV, undefined);
assert.strictEqual(process.env.COMMENTED_ENV_FOLLOW_COMMENTED_ENV_2, undefined); |
Member
|
You should use the snake_case naming convention for local variables and parameters as stated here in the C++ style guide. |
9df5358 to
c42b6a0
Compare
IlyasShabi
commented
Apr 9, 2024
anonrig
reviewed
Apr 9, 2024
c42b6a0 to
077f619
Compare
anonrig
reviewed
Apr 10, 2024
Member
anonrig
left a comment
There was a problem hiding this comment.
Small changes but overall I think this is ready to land. Thank you.
077f619 to
46783d0
Compare
46783d0 to
a723280
Compare
anonrig
approved these changes
Apr 11, 2024
Collaborator
Collaborator
Collaborator
Member
Author
|
Flaky tests |
Member
|
No. Some dotenv tests are broken on Windows. (Search for "not ok" in the output) |
c69d5c3 to
456a29b
Compare
456a29b to
97fa6a0
Compare
IlyasShabi
commented
Apr 12, 2024
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/52406 ✔ Done loading data for nodejs/node/pull/52406 ----------------------------------- PR info ------------------------------------ Title src: remove regex usage for env file parsing (#52406) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch IlyasShabi:dotenv-refacto -> nodejs:main Labels c++, author ready, needs-ci, commit-queue-squash Commits 2 - src: remove regex usage for env file parsing - src: handle empty value without newline at EOF Committers 1 - Ilyas Shabi PR-URL: https://github.com/nodejs/node/pull/52406 Fixes: https://github.com/nodejs/node/issues/52248 Reviewed-By: Yagiz Nizipli ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/52406 Fixes: https://github.com/nodejs/node/issues/52248 Reviewed-By: Yagiz Nizipli -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - src: handle empty value without newline at EOF ℹ This PR was created on Sun, 07 Apr 2024 15:34:18 GMT ✔ Approvals: 1 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/52406#pullrequestreview-1995581300 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-04-16T01:40:19Z: https://ci.nodejs.org/job/node-test-pull-request/58417/ - Querying data for job/node-test-pull-request/58417/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/8699372234 |
targos
reviewed
Apr 16, 2024
78c7bc4 to
e85159d
Compare
Collaborator
anonrig
approved these changes
Apr 16, 2024
Collaborator
Collaborator
Collaborator
|
Landed in 3f88e14 |
Contributor
|
@IlyasShabi thank you so much! do you plan to backport to 20.x too? |
Contributor
|
@RafaelGSS I don't see this PR in the changelog for 22.0.0, was it somehow excluded for whatever reason? It doesn't seem to be fixed in current V22 either. |
Member
|
cc @nodejs/releasers |
Merged
|
Is it possible that with this change inline comments are gone? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to remove regex usage for env file parsing, this will close: