doc: add more definitions to GLOSSARY.md#52798
Merged
nodejs-github-bot merged 6 commits intonodejs:mainfrom May 5, 2024
Merged
doc: add more definitions to GLOSSARY.md#52798nodejs-github-bot merged 6 commits intonodejs:mainfrom
nodejs-github-bot merged 6 commits intonodejs:mainfrom
Conversation
Contributor
|
Can you add the original author as a co-author please? |
Member
Author
|
Sure thing, I must've forgotten when I typed up the commit. |
Contributor
|
Could you move the renaming of the file to simplifies reviews and avoid resetting the git blame? The renaming could probably be fast-tracked as it would be fairly trivial to review. |
aduh95
reviewed
May 3, 2024
aduh95
reviewed
May 3, 2024
aduh95
reviewed
May 3, 2024
VoltrexKeyva
reviewed
May 3, 2024
Co-Authored-By: Harshitha KP <harshi46@in.ibm.com>
jasnell
approved these changes
May 4, 2024
aduh95
reviewed
May 5, 2024
aduh95
reviewed
May 5, 2024
Contributor
aduh95
left a comment
There was a problem hiding this comment.
Almost there, just a few nits left
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
approved these changes
May 5, 2024
4 tasks
Collaborator
|
Landed in f500107 |
Ch3nYuY
pushed a commit
to Ch3nYuY/node
that referenced
this pull request
May 8, 2024
Co-Authored-By: Harshitha KP <harshi46@in.ibm.com> PR-URL: nodejs#52798 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 8, 2024
Co-Authored-By: Harshitha KP <harshi46@in.ibm.com> PR-URL: #52798 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
marco-ippolito
pushed a commit
that referenced
this pull request
Jun 17, 2024
Co-Authored-By: Harshitha KP <harshi46@in.ibm.com> PR-URL: #52798 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Merged
eliphazbouye
pushed a commit
to eliphazbouye/node
that referenced
this pull request
Jun 20, 2024
Co-Authored-By: Harshitha KP <harshi46@in.ibm.com> PR-URL: nodejs#52798 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
bmeck
pushed a commit
to bmeck/node
that referenced
this pull request
Jun 22, 2024
Co-Authored-By: Harshitha KP <harshi46@in.ibm.com> PR-URL: nodejs#52798 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #31879, as no action from the author was taken in several years.
This PR uses the terms/definitions from the original PR and adds more. Additionally, the requested changes from that PR were also taken into account.
Supersedes: #31879