test_runner: refactor coverage to pass in config options#53931
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Jul 22, 2024
Merged
test_runner: refactor coverage to pass in config options#53931nodejs-github-bot merged 1 commit intonodejs:mainfrom
nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
This commit updates the test runner's code coverage so that coverage options are explicitly passed in instead of pulled from command line options.
Collaborator
|
Review requested:
|
MoLow
approved these changes
Jul 18, 2024
atlowChemi
approved these changes
Jul 19, 2024
jasnell
approved these changes
Jul 19, 2024
Collaborator
Member
GeoffreyBooth
left a comment
There was a problem hiding this comment.
Wouldn't the documentation change as a result of this?
Contributor
Author
|
No, this is only an internal refactor. This change is required so that in the future (#53937) the The back story is that the |
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
|
Landed in ea837a0 |
targos
pushed a commit
that referenced
this pull request
Jul 28, 2024
This commit updates the test runner's code coverage so that coverage options are explicitly passed in instead of pulled from command line options. PR-URL: #53931 Refs: #53924 Refs: #53867 Refs: #53866 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 5, 2024
This commit updates the test runner's code coverage so that coverage options are explicitly passed in instead of pulled from command line options. PR-URL: #53931 Refs: #53924 Refs: #53867 Refs: #53866 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates the test runner's code coverage so that coverage options are explicitly passed in instead of pulled from command line options.
Refs: #53924
Refs: #53867
Refs: #53866