lib: fix emit warning for debuglog.time when disabled#54275
Merged
nodejs-github-bot merged 5 commits intonodejs:mainfrom Aug 27, 2024
Merged
lib: fix emit warning for debuglog.time when disabled#54275nodejs-github-bot merged 5 commits intonodejs:mainfrom
nodejs-github-bot merged 5 commits intonodejs:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #54275 +/- ##
==========================================
- Coverage 87.10% 87.10% -0.01%
==========================================
Files 647 648 +1
Lines 181754 182214 +460
Branches 34880 34969 +89
==========================================
+ Hits 158323 158715 +392
- Misses 16742 16786 +44
- Partials 6689 6713 +24
|
jasnell
reviewed
Aug 11, 2024
jasnell
reviewed
Aug 11, 2024
jasnell
reviewed
Aug 11, 2024
jasnell
reviewed
Aug 11, 2024
jasnell
approved these changes
Aug 11, 2024
Co-authored-by: James M Snell <jasnell@gmail.com>
Co-authored-by: James M Snell <jasnell@gmail.com>
Co-authored-by: James M Snell <jasnell@gmail.com>
Co-authored-by: James M Snell <jasnell@gmail.com>
joyeecheung
approved these changes
Aug 15, 2024
Collaborator
RafaelGSS
approved these changes
Aug 21, 2024
Collaborator
Collaborator
Collaborator
Merged
Collaborator
Collaborator
Collaborator
|
Landed in a7271ab |
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 30, 2024
PR-URL: #54275 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 30, 2024
PR-URL: #54275 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
PR-URL: nodejs#54275 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
joyeecheung
pushed a commit
to joyeecheung/node
that referenced
this pull request
Feb 5, 2025
PR-URL: nodejs#54275 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
joyeecheung
pushed a commit
to joyeecheung/node
that referenced
this pull request
Feb 5, 2025
PR-URL: nodejs#54275 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
joyeecheung
pushed a commit
to joyeecheung/node
that referenced
this pull request
Feb 6, 2025
PR-URL: nodejs#54275 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Member
|
Tentatively backport in #56927 to reduce conflicts. Though this is not very essential and might get dropped. |
Member
|
Backing it out from #56927 to avoid introducing surface for regressions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #54265
The code of debuglog.time was executing because the internal flag
timerFlagshad the value7and the comparison was wrong, instead of checking if the enum flags were activated (2 | 4), I was just making a===comparison.Now this behavior is fixed by just doing the comparison correctly, I also added a test to track this regression.
In theory, this bug slowed down a little bit all the
requiresbut not too much since the heavy part was skipped.