test: remove duplicate skip AIX#54917
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Sep 15, 2024
Merged
Conversation
Collaborator
|
Review requested:
|
lpinca
approved these changes
Sep 13, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54917 +/- ##
=======================================
Coverage 88.04% 88.05%
=======================================
Files 651 651
Lines 183409 183409
Branches 35828 35823 -5
=======================================
+ Hits 161487 161500 +13
+ Misses 15174 15163 -11
+ Partials 6748 6746 -2 |
richardlau
approved these changes
Sep 13, 2024
Collaborator
meixg
approved these changes
Sep 13, 2024
jakecastelli
approved these changes
Sep 14, 2024
Collaborator
|
Landed in 6db320a |
RafaelGSS
pushed a commit
that referenced
this pull request
Sep 16, 2024
PR-URL: #54917 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Sep 16, 2024
PR-URL: #54917 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Sep 17, 2024
PR-URL: #54917 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Sep 17, 2024
PR-URL: #54917 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
PR-URL: nodejs#54917 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this pull request
Nov 21, 2024
PR-URL: nodejs#54917 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip AIX is already defined on the top, so the
{ skip: common.isAIX }is duplicated.