Closed
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #55885 +/- ##
==========================================
+ Coverage 90.23% 90.24% +0.01%
==========================================
Files 630 630
Lines 185129 185129
Branches 36234 36238 +4
==========================================
+ Hits 167049 167075 +26
+ Misses 11037 11030 -7
+ Partials 7043 7024 -19 🚀 New features to boost your workflow:
|
jasnell
approved these changes
Nov 23, 2024
ovflowd
reviewed
Jan 26, 2025
Member
There was a problem hiding this comment.
Do we need the lint-md to run on our generated stuff?
Member
|
cc @avivkeller can you rebase? |
aa7ca6b to
65cad89
Compare
Member
Author
|
I've rebased, sorry for the delay. However, I don't this to interfere with #57343, and that should take prriority. I'll resume this once that merges |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tree of #55268 got messed up (sorry!), and I had to recreate.
CC @aduh95 @ovflowd (previous reviewers)
This PR adds generation of the
node.1file to theformat-mdcommand. This way, the manpage is always up-to-date with a new release, as it currently contains outdated (and/or incorrect) information.This is done by using the
@node-core/api-docs-toolingtool. Currently, it is locked to nodejs/doc-kit@bbf44c4 to prevent any future changes from breaking this.