Closed
Conversation
Collaborator
Author
|
Review requested:
|
Collaborator
Author
Member
|
@lemire is this a bug with simdutf or due to extremely old macOS in node.js infra? |
Member
|
It is likely that you are trying to compile C++20 code with a compiler system that is too old to support C++20 properly. I will issue a patch release that checks for the LLVM version and does not rely on what the compiler claims. |
Member
|
@anonrig If I am reading this right, LLVM did something dirty where they claimed that they supported C++20 when they did not. But we can route around this by manually checking the LLVM version. |
Member
|
Closed in favor of #56250. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated update of simdjson to 3.11.2.