You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
TODO: Add/modify tests (will do later, just pushing this to validate that this is the way to go for changes like this).
I just added a flag to make a conditional output. Is this the usual way to go with NodeJS @pmarchini ?
About the feature, I'm not sure if everyone will like it like this. Maybe add an opt-in flag to format the errors before the report has finished? (like it was before, but now is opt-in). Or maybe don't add a flag now, and maybe add the opt-in flag later if we receive complaints?
About the feature, I'm not sure if everyone will like it like this. Maybe add an opt-in flag to format the errors before the report has finished? (like it was before, but now is opt-in). Or maybe don't add a flag now, and maybe add the opt-in flag later if we receive complaints?
It's possible for anyone to write their own reporter to make it look exactly how they want. There are already a number of reporters available on npm, and one potentially in the works for node core. We also don't make semver guarantees about exact reporter formatting.
Can you update the tests so that this doesn't get stalled out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
needs-ciPRs that need a full CI run.test_runnerIssues and PRs related to the test runner subsystem.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #56316
TODO: Add/modify tests (will do later, just pushing this to validate that this is the way to go for changes like this).
I just added a flag to make a conditional output. Is this the usual way to go with NodeJS @pmarchini ?
About the feature, I'm not sure if everyone will like it like this. Maybe add an opt-in flag to format the errors before the report has finished? (like it was before, but now is opt-in). Or maybe don't add a flag now, and maybe add the opt-in flag later if we receive complaints?