test: remove test-runner-watch-mode-complex flaky designation#56470
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Jan 6, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56470 +/- ##
==========================================
+ Coverage 88.53% 88.54% +0.01%
==========================================
Files 657 657
Lines 190719 190761 +42
Branches 36605 36611 +6
==========================================
+ Hits 168848 168906 +58
- Misses 15040 15046 +6
+ Partials 6831 6809 -22 |
jasnell
approved these changes
Jan 4, 2025
Collaborator
jakecastelli
approved these changes
Jan 5, 2025
Collaborator
|
Landed in 984a472 |
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Jan 13, 2025
Refs: nodejs#55006 Refs: nodejs#54807 (comment) PR-URL: nodejs#56470 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #55006
Refs: #54807 (comment)