tools: fix vcbuild test when path contain spaces#56481
Merged
nodejs-github-bot merged 3 commits intonodejs:mainfrom Dec 9, 2025
Merged
tools: fix vcbuild test when path contain spaces#56481nodejs-github-bot merged 3 commits intonodejs:mainfrom
vcbuild test when path contain spaces#56481nodejs-github-bot merged 3 commits intonodejs:mainfrom
Conversation
64b16c5 to
7a4087c
Compare
vcbuild test when path contain spaces
aduh95
approved these changes
Jan 5, 2025
Collaborator
lpinca
reviewed
Jan 5, 2025
lpinca
approved these changes
Jan 5, 2025
Collaborator
Contributor
|
Related failure on Windows: Dropping/Reverting c33319c should fix the issue. |
Member
|
Adding the following patch without reverting c33319c should also fix the issue. diff --git a/vcbuild.bat b/vcbuild.bat
index f93998d2b1..c5fd1a5d0c 100644
--- a/vcbuild.bat
+++ b/vcbuild.bat
@@ -590,9 +590,7 @@ if not defined doc if not defined build_addons (
)
if exist "tools\doc\node_modules\unified\package.json" goto skip-install-doctools
SETLOCAL
-cd tools\doc
-%npm_exe% ci
-cd ..\..
+%npm_exe% --prefix tools\doc ci
if errorlevel 1 goto exit
ENDLOCAL
:skip-install-doctools
@@ -735,9 +733,7 @@ goto lint-js-build
:lint-js-build
if not defined lint_js_build if not defined lint_js if not defined lint_js_fix goto lint-md-build
-cd tools\eslint
-%npm_exe% ci
-cd ..\..
+%npm_exe% --prefix tools\eslint ci
:lint-js
if not defined lint_js goto lint-js-fix
@@ -755,9 +751,7 @@ goto lint-md-build
:lint-md-build
if not defined lint_md if not defined format_md goto lint-md
-cd tools\lint-md
-%npm_exe% ci
-cd ..\..
+%npm_exe% --prefix tools\lint-md ci
:lint-md
if not defined lint_md goto format-md
|
Collaborator
Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
0b3d6fa to
f1b58d2
Compare
Collaborator
Collaborator
Collaborator
Collaborator
aduh95
approved these changes
Dec 9, 2025
Collaborator
|
Landed in 0ffa607 |
aduh95
pushed a commit
that referenced
this pull request
Jan 9, 2026
PR-URL: #56481 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Jan 12, 2026
PR-URL: #56481 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 13, 2026
PR-URL: #56481 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Jan 19, 2026
PR-URL: #56481 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
islandryu
pushed a commit
to islandryu/node
that referenced
this pull request
Jan 25, 2026
PR-URL: nodejs#56481 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.