test: use spawnSyncAndExit{,WithoutError}()#56529
Closed
lpinca wants to merge 1 commit intonodejs:mainfrom
Closed
Conversation
3871b83 to
01e4d77
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56529 +/- ##
==========================================
- Coverage 89.16% 89.16% -0.01%
==========================================
Files 662 662
Lines 191668 191672 +4
Branches 36884 36883 -1
==========================================
- Hits 170908 170905 -3
- Misses 13621 13627 +6
- Partials 7139 7140 +1 |
396e17c to
c57b24a
Compare
Use `spawnSyncAndExit()` and `spawnSyncAndExitWithoutError()` in `test/parallel/test-macos-app-sandbox.js`. Refs: nodejs#54802 (comment)
c57b24a to
b6a59dd
Compare
Collaborator
Member
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
spawnSyncAndExit()andspawnSyncAndExitWithoutError()intest/parallel/test-macos-app-sandbox.js.Refs: #54802 (comment)