Skip to content

tools: edit create-release-proposal workflow to handle pr body length#57841

Merged
nodejs-github-bot merged 3 commits intonodejs:mainfrom
elvessilvavieira:actions/tools-update-release-proposal-creator
Apr 14, 2025
Merged

tools: edit create-release-proposal workflow to handle pr body length#57841
nodejs-github-bot merged 3 commits intonodejs:mainfrom
elvessilvavieira:actions/tools-update-release-proposal-creator

Conversation

@elvessilvavieira
Copy link
Contributor

@elvessilvavieira elvessilvavieira commented Apr 11, 2025

GitHub actions does not allow a body greater than 65536. Therefore, if it exceeds this, it only write the RELEASE_DATE

@RafaelGSS could you pls review it? thx

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 11, 2025

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Apr 11, 2025
RafaelGSS
RafaelGSS approved these changes Apr 11, 2025
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RafaelGSS RafaelGSS added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 11, 2025
@RafaelGSS RafaelGSS requested a review from a team April 11, 2025 22:05
aduh95
aduh95 reviewed Apr 11, 2025
View reviewed changes
@elvessilvavieira @aduh95
tools: improve performance of PR body length handling
9014f9a 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
aduh95 reviewed Apr 12, 2025
View reviewed changes
@elvessilvavieira @aduh95
tools: fix create-release-proposal workflow
125e5a6 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 12, 2025
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 13, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 13, 2025

Commit Queue failed
- Loading data for nodejs/node/pull/57841
✔  Done loading data for nodejs/node/pull/57841
----------------------------------- PR info ------------------------------------
Title      tools: edit create-release-proposal workflow to handle pr body length (#57841)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     elvessilvavieira:actions/tools-update-release-proposal-creator -> nodejs:main
Labels     tools, author ready
Commits    3
 - tools: edit create-release-proposal workflow to handle pr body length
 - tools: improve performance of PR body length handling
 - tools: fix create-release-proposal workflow
Committers 1
 - GitHub <noreply@github.com>
PR-URL: https://github.com/nodejs/node/pull/57841
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/57841
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 11 Apr 2025 21:15:42 GMT
   ✔  Approvals: 2
   ✔  - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/57841#pullrequestreview-2762514063
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/57841#pullrequestreview-2762268610
   ✘  Last GitHub CI failed
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/14433474286

@elvessilvavieira
Copy link
Contributor Author

elvessilvavieira commented Apr 14, 2025

Commit Queue failed

oh... I just update it. it should now be visible

@aduh95 aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Apr 14, 2025
@aduh95 aduh95 mentioned this pull request Apr 14, 2025
Closed
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 14, 2025
@nodejs-github-bot nodejs-github-bot merged commit 958fd91 into nodejs:main Apr 14, 2025
33 checks passed
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 14, 2025

Landed in 958fd91

RafaelGSS pushed a commit that referenced this pull request May 1, 2025
@elvessilvavieira @RafaelGSS
tools: edit create-release-proposal workflow to handle pr body length
498da23 
PR-URL: #57841
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request May 1, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
@elvessilvavieira @RafaelGSS
tools: edit create-release-proposal workflow to handle pr body length
77dee41 
PR-URL: #57841
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 pushed a commit that referenced this pull request May 6, 2025
@elvessilvavieira @aduh95
tools: edit create-release-proposal workflow to handle pr body length
f27f6b8 
PR-URL: #57841
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 pushed a commit that referenced this pull request May 6, 2025
@elvessilvavieira @aduh95
tools: edit create-release-proposal workflow to handle pr body length
84568dc 
PR-URL: #57841
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
@elvessilvavieira @RafaelGSS
tools: edit create-release-proposal workflow to handle pr body length
12c2576 
PR-URL: #57841
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 pushed a commit that referenced this pull request May 16, 2025
@elvessilvavieira @aduh95
tools: edit create-release-proposal workflow to handle pr body length
8241739 
PR-URL: #57841
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@elvessilvavieira @aduh95
tools: edit create-release-proposal workflow to handle pr body length
e5709a3 
PR-URL: #57841
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@elvessilvavieira @aduh95
tools: edit create-release-proposal workflow to handle pr body length
0f30497 
PR-URL: #57841
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@elvessilvavieira @aduh95
tools: edit create-release-proposal workflow to handle pr body length
a7a8929 
PR-URL: #57841
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 pushed a commit that referenced this pull request May 18, 2025
@elvessilvavieira @aduh95
tools: edit create-release-proposal workflow to handle pr body length
9445eaa 
PR-URL: #57841
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@github-actions github-actions bot mentioned this pull request May 19, 2025
Merged
aduh95 pushed a commit that referenced this pull request May 19, 2025
@elvessilvavieira @aduh95
tools: edit create-release-proposal workflow to handle pr body length
938f153 
PR-URL: #57841
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Jun 5, 2025
@elvessilvavieira @marco-ippolito
tools: edit create-release-proposal workflow to handle pr body length
eafacab 
PR-URL: #57841
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Jun 5, 2025
@elvessilvavieira @marco-ippolito
tools: edit create-release-proposal workflow to handle pr body length
75a49d8 
PR-URL: #57841
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@marco-ippolito marco-ippolito mentioned this pull request Jun 5, 2025
Merged
@ghost ghost mentioned this pull request Jun 8, 2025
Closed
marco-ippolito pushed a commit that referenced this pull request Jun 10, 2025
@elvessilvavieira @marco-ippolito
tools: edit create-release-proposal workflow to handle pr body length
a1afb8f 
PR-URL: #57841
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Jun 11, 2025
@elvessilvavieira @marco-ippolito
tools: edit create-release-proposal workflow to handle pr body length
414013d 
PR-URL: #57841
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95 aduh95 aduh95 approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@elvessilvavieira @nodejs-github-bot @aduh95 @RafaelGSS