Review requested:

• @nodejs/actions

cc @nodejs/platform-macos @nodejs/cpp-reviewers any idea how to fix this error?

cc @nodejs/platform-macos @nodejs/cpp-reviewers any idea how to fix this error?

I have no insights on how to fix the error, but if anyone is trying to recreate please note that the GitHub workflow deliberately runs with configure --error-on-warn which treats all warnings as errors.

Could be #54576

The error is from https://github.com/v8/v8/blob/91d3eb34ec7936b5d1d4832192e1d6691c085fc0/include/v8-persistent-handle.h#L482-L497

I know from my V8 clone's ninja files that V8's build config sets -Wno-cast-function-type.
Since the warning comes from a V8 public header, it looks like we would have to disable this warning globally in our build.

I was trying to build main today on my mac (arm), my os was 15.1 and I got a bunch of errors building v8 similar to above @targos mentioned. But after upgrading my os to 15.4.1 the problem goes away.

I opened nodejs/build#4083 to discuss the Jenkins CI update.

This has been done in multiple smaller PRs and now the CI is updated.