Skip to content

Test runner/revert/#56664#58320

Closed
pmarchini wants to merge 4 commits intonodejs:mainfrom
pmarchini:test_runner/revert/#56664
Closed

Test runner/revert/#56664#58320
pmarchini wants to merge 4 commits intonodejs:mainfrom
pmarchini:test_runner/revert/#56664

Conversation

@pmarchini
Copy link
Member

@pmarchini pmarchini commented May 14, 2025

This PR is a follow-up to #58282!

cc @romainmenke (if the changes are okay with others, I'd say you could just cherry-pick them into your PR)

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 14, 2025

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels May 14, 2025
@pmarchini
Copy link
Member Author

pmarchini commented May 14, 2025

@jakecastelli, could I please ask you to take a look at the latest commit?

pmarchini
pmarchini commented May 14, 2025
View reviewed changes
pmarchini
pmarchini commented May 14, 2025
View reviewed changes
@codecov
Copy link

codecov bot commented May 14, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.24%. Comparing base (770be2c) to head (544df03).
Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/test_runner/harness.js 85.71% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #58320      +/-   ##
==========================================
+ Coverage   90.18%   90.24%   +0.05%     
==========================================
  Files         631      633       +2     
  Lines      186689   186793     +104     
  Branches    36663    36669       +6     
==========================================
+ Hits       168359   168564     +205     
+ Misses      11128    11030      -98     
+ Partials     7202     7199       -3
Files with missing lines Coverage Δ
lib/internal/test_runner/test.js 97.11% <100.00%> (-0.03%) ⬇️
lib/internal/test_runner/harness.js 93.13% <85.71%> (-0.22%) ⬇️

... and 43 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pmarchini pmarchini force-pushed the test_runner/revert/#56664 branch from 7557818 to b7edccf Compare May 14, 2025 13:49
@pmarchini pmarchini force-pushed the test_runner/revert/#56664 branch from b7edccf to 544df03 Compare May 14, 2025 14:07
@pmarchini pmarchini closed this May 14, 2025
@pmarchini pmarchini mentioned this pull request May 14, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakecastelli jakecastelli jakecastelli left review comments

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pmarchini @nodejs-github-bot @jakecastelli @romainmenke