Skip to content

os: fix GetInterfaceAddresses memory leaky#58940

Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom
theanarkh:fix_GetInterfaceAddresses_memory_leaky
Jul 5, 2025
Merged

os: fix GetInterfaceAddresses memory leaky#58940
nodejs-github-bot merged 1 commit intonodejs:mainfrom
theanarkh:fix_GetInterfaceAddresses_memory_leaky

Conversation

@theanarkh
Copy link
Contributor

@theanarkh theanarkh commented Jul 3, 2025

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. os Issues and PRs related to the os subsystem. labels Jul 3, 2025
juanarbol
juanarbol approved these changes Jul 3, 2025
View reviewed changes
Copy link
Member

@juanarbol juanarbol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@theanarkh theanarkh force-pushed the fix_GetInterfaceAddresses_memory_leaky branch from 662ef66 to 3b11dbf Compare July 3, 2025 01:25
@codecov
Copy link

codecov bot commented Jul 3, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.08%. Comparing base (ba8fbf3) to head (3b11dbf).
Report is 998 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #58940      +/-   ##
==========================================
- Coverage   90.37%   90.08%   -0.29%     
==========================================
  Files         629      640      +11     
  Lines      184373   188473    +4100     
  Branches    36022    36972     +950     
==========================================
+ Hits       166624   169783    +3159     
- Misses      10906    11422     +516     
- Partials     6843     7268     +425
Files with missing lines Coverage Δ
src/node_os.cc 80.00% <100.00%> (+1.26%) ⬆️

... and 322 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@legendecas legendecas added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jul 4, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 4, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 4, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/67840/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 5, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/67851/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 5, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/67854/

@theanarkh theanarkh added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 5, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 5, 2025
@nodejs-github-bot nodejs-github-bot merged commit b890c51 into nodejs:main Jul 5, 2025
64 checks passed
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 5, 2025

Landed in b890c51

RafaelGSS pushed a commit that referenced this pull request Jul 8, 2025
@theanarkh @RafaelGSS
os: fix GetInterfaceAddresses memory lieaky
7f7a833 
PR-URL: #58940
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@github-actions github-actions bot mentioned this pull request Jul 8, 2025
Merged
aduh95 pushed a commit that referenced this pull request Jul 21, 2025
@theanarkh @aduh95
os: fix GetInterfaceAddresses memory lieaky
232879b 
PR-URL: #58940
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95 pushed a commit that referenced this pull request Jul 24, 2025
@theanarkh @aduh95
os: fix GetInterfaceAddresses memory lieaky
a8a1c9a 
PR-URL: #58940
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@github-actions github-actions bot mentioned this pull request Jul 28, 2025
Merged
marco-ippolito pushed a commit that referenced this pull request Aug 18, 2025
@theanarkh @marco-ippolito
os: fix GetInterfaceAddresses memory lieaky
eb71e3f 
PR-URL: #58940
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@marco-ippolito marco-ippolito mentioned this pull request Aug 20, 2025
Merged
marco-ippolito pushed a commit that referenced this pull request Aug 20, 2025
@theanarkh @marco-ippolito
os: fix GetInterfaceAddresses memory lieaky
ecfca31 
PR-URL: #58940
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Aug 23, 2025
@theanarkh @marco-ippolito
os: fix GetInterfaceAddresses memory lieaky
66fc76a 
PR-URL: #58940
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Aug 25, 2025
@theanarkh @marco-ippolito
os: fix GetInterfaceAddresses memory lieaky
fb53e06 
PR-URL: #58940
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Aug 25, 2025
@theanarkh @marco-ippolito
os: fix GetInterfaceAddresses memory lieaky
e4af0e5 
PR-URL: #58940
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Aug 25, 2025
@theanarkh @marco-ippolito
os: fix GetInterfaceAddresses memory lieaky
2175bab 
PR-URL: #58940
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Aug 25, 2025
@theanarkh @marco-ippolito
os: fix GetInterfaceAddresses memory lieaky
0cfcb78 
PR-URL: #58940
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Aug 26, 2025
@theanarkh @marco-ippolito
os: fix GetInterfaceAddresses memory lieaky
018a97b 
PR-URL: #58940
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Aug 27, 2025
@theanarkh @marco-ippolito
os: fix GetInterfaceAddresses memory lieaky
043dcdd 
PR-URL: #58940
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@legendecas legendecas legendecas approved these changes

@juanarbol juanarbol juanarbol approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. os Issues and PRs related to the os subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@theanarkh @nodejs-github-bot @legendecas @juanarbol